Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchance use of data_range in image metrics #1606

Merged
merged 13 commits into from
Mar 28, 2023
Merged

Enchance use of data_range in image metrics #1606

merged 13 commits into from
Mar 28, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1592
Add additional option for the data_range to be used as an tuple that auto clamps input.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 10, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 10, 2023
@SkafteNicki SkafteNicki requested a review from Borda as a code owner March 10, 2023 09:46
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1606 (526cf75) into master (b613c50) will decrease coverage by 48%.
The diff coverage is 84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1606     +/-   ##
========================================
- Coverage      89%     41%    -48%     
========================================
  Files         228     228             
  Lines       12365   12379     +14     
========================================
- Hits        10947    5018   -5929     
- Misses       1418    7361   +5943     

@Borda Borda enabled auto-merge (squash) March 10, 2023 10:59
@mergify mergify bot added the ready label Mar 10, 2023
@mergify mergify bot requested a review from a team March 10, 2023 11:00
@Borda Borda requested a review from stancld March 13, 2023 22:49
@Borda Borda disabled auto-merge March 15, 2023 20:05
@Borda Borda enabled auto-merge (squash) March 15, 2023 20:08
@mergify mergify bot removed the has conflicts label Mar 21, 2023
@Borda Borda disabled auto-merge March 28, 2023 10:17
@Borda Borda merged commit 82a5f6d into master Mar 28, 2023
@Borda Borda deleted the feature/data_range branch March 28, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clamp image before PSNR and MS-SSIM
2 participants