-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MiFID implementation #1580
Add MiFID implementation #1580
Conversation
I recognize this still needs a fair amount of work before it can be added in. I don't have time at the moment to finish the implementation and add the tests, but I hope to get back to it in the near future. |
Cool, please let us know if you need help with anything :) |
@Dibz15 could you pls allow maintainers to push to this PR / your fork so we can help to finish it? 🐿️ |
@Borda Sorry, should be editable now |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1580 +/- ##
======================================
- Coverage 87% 87% -0%
======================================
Files 258 259 +1
Lines 14589 14672 +83
======================================
+ Hits 12729 12787 +58
- Misses 1860 1885 +25 |
What does this PR do?
Fixes #1578
This is a start of an MiFID implementation, based on the current FID implementation
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃