Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleaning after classification refactor 2/n #1252

Merged
merged 77 commits into from
Nov 22, 2022
Merged

Code cleaning after classification refactor 2/n #1252

merged 77 commits into from
Nov 22, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 5, 2022 •
edited by Borda
Loading

What does this PR do?

Follow up to #1251
Cleaning after the classification refactor.
This PR cleans the functional classification metrics.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the refactoring refactoring and code health label Oct 5, 2022
@SkafteNicki SkafteNicki changed the title functionals cleanup Code cleaning after classification refactor 1/n Oct 5, 2022
@SkafteNicki SkafteNicki changed the title Code cleaning after classification refactor 1/n Code cleaning after classification refactor 2/n Oct 5, 2022
@Borda Borda added this to the v0.11 milestone Oct 5, 2022
@SkafteNicki SkafteNicki mentioned this pull request Oct 6, 2022
Closed
4 tasks
@Borda
Copy link
Member

Borda commented Oct 25, 2022

@SkafteNicki how are we going here? 🦦

@SkafteNicki SkafteNicki marked this pull request as ready for review October 31, 2022 13:15
justusschock
justusschock approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda
Copy link
Member

Borda commented Nov 17, 2022

@SkafteNicki added back some simple doctest as it is not good to have in codebase code which is not ever tested :) an it turned out there are some parameters issues 🤔

@mergify mergify bot removed the has conflicts label Nov 22, 2022
@Borda Borda enabled auto-merge (squash) November 22, 2022 11:30
@mergify mergify bot added the ready label Nov 22, 2022
@Borda Borda merged commit 20eab43 into master Nov 22, 2022
@Borda Borda deleted the cleanup/2 branch November 22, 2022 13:45
@zhiqiangdon zhiqiangdon mentioned this pull request Dec 6, 2022
Closed
@sararb sararb mentioned this pull request Dec 13, 2022
Merged
@carbocation carbocation mentioned this pull request Jan 3, 2023
Closed
@Borda Borda mentioned this pull request Jun 23, 2023
Closed
4 tasks
@adamjstewart
Copy link
Contributor

It seems that mdmc_average was removed. Is multidim_average equivalent?

@adamjstewart adamjstewart mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton Awaiting requested review from tchaton

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees

@SkafteNicki SkafteNicki

Labels
ready refactoring refactoring and code health
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@SkafteNicki @Borda @adamjstewart @justusschock