Code cleaning after classification refactor 2/n #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
changed the title
SkafteNicki
changed the title
4 tasks
|
@SkafteNicki how are we going here? 🦦 |
SkafteNicki
requested review from
Borda,
justusschock,
tchaton and
ethanwharris
as code owners
|
Also needs to add the changes from #1254 because everything is connected |
Borda
approved these changes
Nov 17, 2022
|
@SkafteNicki added back some simple doctest as it is not good to have in codebase code which is not ever tested :) an it turned out there are some parameters issues 🤔 |
4 tasks
|
It seems that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #1251
Cleaning after the classification refactor.
This PR cleans the functional classification metrics.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃