Fix: no_grad with AMP bug
#20921
Open
Fix: no_grad with AMP bug
#20921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baskrahmer
force-pushed
the
fix/no-grad-amp-bug
branch
from
08508b6 to
d18fb08
Compare
baskrahmer
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20644
Note however that this would affect performance for other users, so the question is whether it is worth optimizing for this edge case that is fundamentally a
torchbug.cc @Borda
📚 Documentation preview 📚: https://pytorch-lightning--20921.org.readthedocs.build/en/20921/