Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: replace macOS-11 with macOS-14 #20029

Merged
merged 2 commits into from
Jun 30, 2024
Merged

CI: replace macOS-11 with macOS-14 #20029

merged 2 commits into from
Jun 30, 2024

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 30, 2024

What does this PR do?

The macOS-11 image for our GitHub actions was deprecated and removed recently, which is why the jobs are not starting. See https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

This PR replaces all macOS-11 with macOS-14.


📚 Documentation preview 📚: https://pytorch-lightning--20029.org.readthedocs.build/en/20029/

cc @Borda

@github-actions github-actions bot added ci Continuous Integration app (removed) Generic label for Lightning App package labels Jun 30, 2024
Copy link
Contributor

github-actions bot commented Jun 30, 2024

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-13, lightning, 3.8, 2.0, oldest) success
pl-cpu (macOS-14, lightning, 3.10, 2.0) success
pl-cpu (macOS-14, lightning, 3.10, 2.1) success
pl-cpu (macOS-14, lightning, 3.10, 2.2) success
pl-cpu (macOS-14, lightning, 3.10, 2.3) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3) success
pl-cpu (windows-2022, lightning, 3.8, 2.0, oldest) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.10, 2.1) success
pl-cpu (windows-2022, lightning, 3.10, 2.2) success
pl-cpu (windows-2022, lightning, 3.10, 2.3) success
pl-cpu (macOS-14, pytorch, 3.8, 2.0) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.0) success
pl-cpu (windows-2022, pytorch, 3.8, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.0) success
pl-cpu (macOS-12, pytorch, 3.11, 2.1) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0) success
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1) success
pl-cpu (windows-2022, pytorch, 3.11, 2.0) success
pl-cpu (windows-2022, pytorch, 3.11, 2.1) success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-13, lightning, 3.8, 2.0, oldest) success
fabric-cpu (macOS-14, lightning, 3.10, 2.0) success
fabric-cpu (macOS-14, lightning, 3.11, 2.1) success
fabric-cpu (macOS-14, lightning, 3.11, 2.2) success
fabric-cpu (macOS-14, lightning, 3.10, 2.3) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.0, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2) success
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3) success
fabric-cpu (windows-2022, lightning, 3.8, 2.0, oldest) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.11, 2.1) success
fabric-cpu (windows-2022, lightning, 3.11, 2.2) success
fabric-cpu (windows-2022, lightning, 3.11, 2.3) success
fabric-cpu (macOS-14, fabric, 3.8, 2.0) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.0) success
fabric-cpu (windows-2022, fabric, 3.8, 2.0) success
fabric-cpu (macOS-12, fabric, 3.11, 2.0) success
fabric-cpu (macOS-12, fabric, 3.11, 2.1) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0) success
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1) success
fabric-cpu (windows-2022, fabric, 3.11, 2.0) success
fabric-cpu (windows-2022, fabric, 3.11, 2.1) success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@awaelchli awaelchli removed the app (removed) Generic label for Lightning App package label Jun 30, 2024
@awaelchli awaelchli added this to the 2.4 milestone Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56%. Comparing base (2524864) to head (bff2b6a).
Report is 74 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (2524864) and HEAD (bff2b6a). Click for more details.

HEAD has 402 uploads less than BASE
Flag BASE (2524864) HEAD (bff2b6a)
python3.10 35 16
cpu 145 48
lightning 86 30
pytest 103 24
gpu 4 0
lightning_fabric 25 9
pytorch_lightning 20 9
examples 9 0
app 9 0
tpu 2 0
python3.8 25 12
python3.11 50 20
lightning_app 9 0
pytorch2.3 7 3
pytest-full 48 24
pytorch2.0 24 12
pytorch2.1 12 6
pytorch2.2 5 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20029     +/-   ##
=========================================
- Coverage      84%      56%    -28%     
=========================================
  Files         427      422      -5     
  Lines       35505    35407     -98     
=========================================
- Hits        29782    19890   -9892     
- Misses       5723    15517   +9794     

@Borda Borda changed the title Replace macOS-11 with macOS-14 CI: replace macOS-11 with macOS-14 Jun 30, 2024
@awaelchli awaelchli merged commit 5636fe4 into master Jun 30, 2024
61 checks passed
@awaelchli awaelchli deleted the ci/macos-11 branch June 30, 2024 20:19
@awaelchli awaelchli modified the milestones: 2.4, 2.3.x Jul 5, 2024
awaelchli added a commit that referenced this pull request Jul 5, 2024
lantiga pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants