-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: replace macOS-11 with macOS-14 #20029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
tchaton,
lantiga,
ethanwharris,
Borda and
justusschock
as code owners
June 30, 2024 16:50
github-actions
bot
added
ci
Continuous Integration
app (removed)
Generic label for Lightning App package
labels
Jun 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20029 +/- ##
=========================================
- Coverage 84% 56% -28%
=========================================
Files 427 422 -5
Lines 35505 35407 -98
=========================================
- Hits 29782 19890 -9892
- Misses 5723 15517 +9794 |
Borda
approved these changes
Jun 30, 2024
Borda
changed the title
Replace macOS-11 with macOS-14
CI: replace macOS-11 with macOS-14
Jun 30, 2024
awaelchli
added a commit
that referenced
this pull request
Jul 5, 2024
lantiga
pushed a commit
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The macOS-11 image for our GitHub actions was deprecated and removed recently, which is why the jobs are not starting. See https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/
This PR replaces all macOS-11 with macOS-14.
📚 Documentation preview 📚: https://pytorch-lightning--20029.org.readthedocs.build/en/20029/
cc @Borda