Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new state-dict APIs in FSDPStrategy #20060

Open
awaelchli opened this issue Jul 8, 2024 · 1 comment
Open

Use new state-dict APIs in FSDPStrategy #20060

awaelchli opened this issue Jul 8, 2024 · 1 comment
Labels
feature Is an improvement or enhancement refactor strategy: fsdp Fully Sharded Data Parallel

Comments

@awaelchli
Copy link
Contributor

awaelchli commented Jul 8, 2024 •
edited
Loading

Description & Motivation

In PyTorch 2.4, the state-dict context managers we use in FSDPStrategy are being deprecated with FutureWarning in PyTorch 2.4. In #20010 I'm suppressing these warnings temporarily.

Pitch

Use the new torch.distributed.checkpoint APIs for PyTorch >= 2.4.

Alternatives

No response

Additional context

No response

cc @Borda @justusschock @awaelchli @carmocca
@awaelchli awaelchli added feature Is an improvement or enhancement needs triage Waiting to be triaged by maintainers refactor strategy: fsdp Fully Sharded Data Parallel and removed needs triage Waiting to be triaged by maintainers labels Jul 8, 2024
@awaelchli awaelchli mentioned this issue Jul 8, 2024
Merged
@carmocca
Copy link
Contributor

carmocca commented Jul 8, 2024

fyi: #19462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement refactor strategy: fsdp Fully Sharded Data Parallel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awaelchli @carmocca