Python 3.8 testing

Author: awaelchli

tests/tests_pytorch/checkpointing/test_model_checkpoint.py

@@ -534,23 +534,23 @@ def test_model_checkpoint_link_checkpoint(tmp_path):
     ModelCheckpoint._link_checkpoint(trainer, filepath=str(file), linkpath=str(link))
     assert os.path.islink(link)
     assert os.path.realpath(link) == str(file)
-    assert not link.readlink().is_absolute()
+    assert not os.path.isabs(os.readlink(link))
 
     # link exists (is a file)
     new_file1 = tmp_path / "new_file1"
     new_file1.touch()
     ModelCheckpoint._link_checkpoint(trainer, filepath=str(new_file1), linkpath=str(link))
     assert os.path.islink(link)
     assert os.path.realpath(link) == str(new_file1)
-    assert not link.readlink().is_absolute()
+    assert not os.path.isabs(os.readlink(link))
 
     # link exists (is a link)
     new_file2 = tmp_path / "new_file2"
     new_file2.touch()
     ModelCheckpoint._link_checkpoint(trainer, filepath=str(new_file2), linkpath=str(link))
     assert os.path.islink(link)
     assert os.path.realpath(link) == str(new_file2)
-    assert not link.readlink().is_absolute()
+    assert not os.path.isabs(os.readlink(link))
 
     # link exists (is a folder)
     folder = tmp_path / "folder"
@@ -560,15 +560,15 @@ def test_model_checkpoint_link_checkpoint(tmp_path):
     ModelCheckpoint._link_checkpoint(trainer, filepath=str(folder), linkpath=str(folder_link))
     assert os.path.islink(folder_link)
     assert os.path.realpath(folder_link) == str(folder)
-    assert not folder_link.readlink().is_absolute()
+    assert not os.path.isabs(os.readlink(folder_link))
 
     # link exists (is a link to a folder)
     new_folder = tmp_path / "new_folder"
     new_folder.mkdir()
     ModelCheckpoint._link_checkpoint(trainer, filepath=str(new_folder), linkpath=str(folder_link))
     assert os.path.islink(folder_link)
     assert os.path.realpath(folder_link) == str(new_folder)
-    assert not folder_link.readlink().is_absolute()
+    assert not os.path.isabs(os.readlink(folder_link))
 
     # simulate permission error on Windows (creation of symbolic links requires privileges)
     file = tmp_path / "win_file"
@@ -592,8 +592,8 @@ def test_model_checkpoint_link_checkpoint_relative_path(tmp_path, monkeypatch):
     link = folder / "link"
     ModelCheckpoint._link_checkpoint(trainer, filepath=str(file.absolute()), linkpath=str(link.absolute()))
     assert os.path.islink(link)
-    assert link.readlink() == file.relative_to(folder)
-    assert not link.readlink().is_absolute()
+    assert Path(os.readlink(link)) == file.relative_to(folder)
+    assert not os.path.isabs(os.readlink(link))
 
 
 def test_invalid_top_k(tmpdir):