Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fsspec to download files #181

Open
samsja opened this issue Jun 23, 2024 · 5 comments · Fixed by #348
Open

Using fsspec to download files #181

samsja opened this issue Jun 23, 2024 · 5 comments · Fixed by #348
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@samsja
Copy link

samsja commented Jun 23, 2024

🚀 Feature

I was wondering if you planned on using fsspec for downloading file. Since fsspec is already compatible with many cloud provider it would make lit-data streaming compatible with even more cloud.

Motivation

Right now there is one downloader class for each provider, fsspec would allow to abstract it away, reducing the amount of cloud provider specific code and allowing supporting more out of the box

PS: love the work on lit data

@samsja samsja added enhancement New feature or request help wanted Extra attention is needed labels Jun 23, 2024
Copy link

Hi! thanks for your contribution!, great first issue!

@tchaton
Copy link
Collaborator

tchaton commented Jun 24, 2024

Hey @samsja, feel free to contribute fsspec support

@samsja
Copy link
Author

samsja commented Jun 24, 2024

Hey @samsja, feel free to contribute fsspec support

Sure, I can give it a try

@deependujha
Copy link
Collaborator

Hey @samsja, there has been no update from your side regarding any progress.

So, I'd like to work on this.

If you have any issue, plz let me know.

@samsja
Copy link
Author

samsja commented Sep 2, 2024

Hey @samsja, there has been no update from your side regarding any progress.

So, I'd like to work on this.

If you have any issue, plz let me know.

Unfortunately, I don't have time right now to check this. Feel free to take it

@bhimrazy bhimrazy reopened this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants