Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Jul 21, 2025

What does this PR do?

This PR updates the CI testing setup to use uv for faster installation. - (1/n)

Note: This PR does not yet include updates to the pyproject.toml.

Inspired from Lightning-AI/LitServe#563

Installation time reduced (~ 2-5 m) as follows:

OS Python Version Before After (with uv)
ubuntu 3.11 install - 2m 45s
test - 37m 8s
install - 9s
test - 34m 59s
ubuntu 3.12 install - 2m 43s
test - 48m 16s
install - 11s
test - 46m 3s
mac-os 3.10 install - 1m 19s
test - 32m 49s
install - 12s
test - 35m 26s
mac-os 3.11 install - 1m 52s
test - 35m 26s
install - 10s
test - 34m 3s
windows 3.11 install - 5m 15s
test - 21m 56s
install - 20s
test - 21m 45s
windows 3.12 install - 5m 14s
test - 27m 24s
install - 19s
test - 26m 8s

Ref Runs: before & after

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy self-assigned this Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83%. Comparing base (fa2020e) to head (92499fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #656   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        49     49           
  Lines      6812   6812           
===================================
+ Hits       5686   5688    +2     
+ Misses     1126   1124    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhimrazy bhimrazy marked this pull request as ready for review July 21, 2025 09:42
Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Also tried make setup in lightning-studio with uv. Super fast!⚡️

Co-authored-by: Deependu <deependujha21@gmail.com>
@bhimrazy bhimrazy added the enhancement New feature or request label Jul 21, 2025
@tchaton tchaton merged commit a34674e into Lightning-AI:main Jul 22, 2025
35 checks passed
@bhimrazy bhimrazy deleted the ci/upgrade-to-uv branch July 22, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci / tests enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants