Skip to content

Upd/hf-dataset-get-format #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Mar 23, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR updates the data retrieval format at sample level by enabling the option for named. And also updates the test cases.
image

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (3602a36) to head (4c9bb07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #522   +/-   ##
===================================
  Coverage    79%    79%           
===================================
  Files        39     39           
  Lines      5888   5888           
===================================
  Hits       4648   4648           
  Misses     1240   1240           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tchaton tchaton marked this pull request as ready for review March 23, 2025 20:54
@tchaton tchaton merged commit 1c8ab3f into Lightning-AI:main Mar 23, 2025
34 of 35 checks passed
@bhimrazy bhimrazy added the enhancement New feature or request label Mar 23, 2025
@bhimrazy bhimrazy self-assigned this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants