Skip to content

Fix: Ensure Compression Algorithm is Installed Before Reading Compressed Data #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix: Ensure Compression Algorithm is Installed Before Reading Compressed Data #342

merged 2 commits into from
Aug 28, 2024

Conversation

bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Aug 27, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Added the same version of the check as seen in L93 from writer.py.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bhimrazy bhimrazy self-assigned this Aug 27, 2024
@bhimrazy bhimrazy changed the title fix: adds compression algorithm check Fix: Ensure Compression Algorithm is Installed Before Reading Compressed Data Aug 27, 2024
@bhimrazy bhimrazy requested a review from Borda August 27, 2024 07:03
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (ee4ff91) to head (506d899).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #342   +/-   ##
===================================
- Coverage    78%    78%   -0%     
===================================
  Files        34     34           
  Lines      5002   5006    +4     
===================================
+ Hits       3918   3920    +2     
- Misses     1084   1086    +2     

@gluonfield
Copy link

Looks good!

@gluonfield
Copy link

Really nice!

@bhimrazy bhimrazy requested a review from deependujha August 28, 2024 09:31
@deependujha deependujha merged commit e97fd61 into Lightning-AI:main Aug 28, 2024
29 checks passed
@bhimrazy bhimrazy deleted the fix/add-compressor-check branch August 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants