Skip to content

Commit e0c6ffe

Browse files
bhimrazydeependujhaBorda
authored
CI: update testing matrix for Python versions (3.12 & 3.13) (#589)
* update CI testing matrix to include Python 3.12 and 3.13 * increasing the timeout time , but not sure why the new versions are taking more time * Update .github/workflows/ci-testing.yml * Apply suggestions from code review * test few updates to ci * update * revert changes * with pytest-cov * bump * ex Win * cov * --capture=tee-sys --exitfirst * PYTHONMULTIPROCESSING_SPAWN: "spawn" * --skip=processing --skip=streaming * --ignore=processing --ignore=streaming * --ignore=streaming * --ignore=processing * Update .github/workflows/ci-testing.yml * --ignore=processing/functions.py * ignore processor and functions from processing * ignore readers * ignore correct files * let's just keep data processor now * ignore macos for higher versions * check for : ignore test_functions.py * skip a few tests under functions.py * ignore other than `test_functions` to speedup * fix: correct typo in ignore flag for pytest command * ignore few more * ignore more * temporarily skip multiple tests in test_functions.py * remove temporary skip from test_map_with_path * remove temporary skip from test_optimize_with_jpeg_array * just keep skip for: test_optimize_checkpoint_in_none_and_append_mode * update test_optimize_checkpoint_in_none_and_append_mode to skip based on Python version and platform * remove test ignores from CI workflow --------- Co-authored-by: Deependu <deependujha21@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: Jirka B <j.borovec+github@gmail.com>
1 parent abfebfd commit e0c6ffe

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

.github/workflows/ci-testing.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,14 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
os: ["ubuntu-22.04", "macos-14", "windows-2022"]
22-
python-version: ["3.9", "3.10", "3.11"]
22+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
23+
exclude:
24+
- { os: "windows-2022", python-version: "3.13" }
25+
- { os: "macos-14", python-version: "3.12" }
26+
- { os: "macos-14", python-version: "3.13" }
2327

2428
# Timeout: https://stackoverflow.com/a/59076067/4521646
25-
timeout-minutes: 45
29+
timeout-minutes: 60
2630
env:
2731
TORCH_URL: "https://download.pytorch.org/whl/cpu/torch_stable.html"
2832

@@ -42,9 +46,11 @@ jobs:
4246
pip list
4347
4448
- name: Tests
45-
run: coverage run --source litdata -m pytest tests -v --durations=100
49+
working-directory: tests
50+
run: pytest . -v --cov=litdata --durations=100
4651

4752
- name: Statistics
53+
continue-on-error: true
4854
run: |
4955
coverage report
5056
coverage xml

requirements/test.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
coverage ==7.6.*
1+
coverage ==7.8.*
22
cryptography==42.0.8
33
mosaicml-streaming==0.11.0
44
pytest ==8.4.*
5-
pytest-cov ==5.0.0
5+
pytest-cov ==6.1.1
66
pytest-timeout ==2.3.1
77
pytest-rerunfailures ==14.0
88
pytest-random-order ==1.1.1

tests/processing/test_functions.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ def test_optimize_append_overwrite(tmpdir):
225225
assert ds[:] == [(i, i**2, i**3) for i in range(0, 5)]
226226

227227

228+
@pytest.mark.skipif(sys.version_info >= (3, 12), reason="Multiprocessing issues on Python 3.12+")
228229
@pytest.mark.skipif(sys.platform == "win32", reason="too slow")
229230
def test_optimize_checkpoint_in_none_and_append_mode(tmpdir):
230231
output_dir = str(tmpdir / "output_dir")

0 commit comments

Comments
 (0)