Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy properties in concrete classes that inherit from an abstract class #133

Open
raacampbell opened this issue Sep 26, 2024 · 0 comments
Open

Comments

@raacampbell
Copy link

This comment is associated with a openjournals/joss-reviews#7275.

I look at MIC_Camera_Abstract and it declares a bunch of properties. Most or all of these are then declared again in the concrete classes, such as MIC_DCAM4Camera. It is confusing if stuff is apparently declared twice. If this is being done to avoid having to define abstract properties to get a concrete class, then why not just do not set the optional properties as Abstract? This is preferable to the apparent redundancy there currently is.

Likely the same thing is happening in other classes, but I didn't check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant