libvncclient: Add qemu extended key event #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk138
requested changes
Dec 2, 2020
Member
bk138
left a comment
bk138
left a comment
There was a problem hiding this comment.
Very nice PR! Thank you! One minor change request.
any1
force-pushed
the
qemu-extended-key-event
branch
from
a612987 to
e147a62
Compare
Contributor
Author
|
Changes made per request. |
bk138
requested changes
Dec 2, 2020
This function sends Qemu extended key events to servers that support such messages. It returns FALSE if the event is not supported.
any1
force-pushed
the
qemu-extended-key-event
branch
from
e147a62 to
0becaf7
Compare
bk138
approved these changes
Dec 2, 2020
bk138
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds qemu extended key events to libvncclient, which greatly simplifies key event handling and improves robustness over the standard method.
An example of the new function call,
SendExtendedKeyEvent, being used can be found here: https://github.com/any1/wlvncc/blob/qemu-extended-key-event/src/vnc.c#L215-L226This functionality was tested using https://github.com/any1/wayvnc/tree/qemu-kb-ext & https://github.com/any1/neatvnc/tree/qemu-kb-ext.