Add db.getMany(keys)
#725
Merged
Add db.getMany(keys)
#725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vweevers
added
enhancement
15 tasks
vweevers
commented
Sep 28, 2021
| const db = testCommon.factory() | ||
|
|
||
| fn(t, db, function (err) { | ||
| t.ifError(err, 'no test error') | ||
| db.close(t.end.bind(t)) | ||
| }) | ||
|
|
||
| // we should still be in a state of limbo down here, not opened or closed, but 'new' |
There was a problem hiding this comment.
Note, behavior didn't change here. The comment was just outdated / incorrect.
This comment has been minimized.
This comment has been minimized.
As well as the encoding-down and memdown devDependencies. Adds `db.status` and `db.isOperational()` for API parity. Ref Level/deferred-leveldown#90
ralphtheninja
approved these changes
Oct 1, 2021
vweevers
added a commit
to Level/subleveldown
that referenced
this pull request
Oct 1, 2021
vweevers
added a commit
to Level/subleveldown
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Level/community#101. Depends on Level/memdown#212, Level/encoding-down#102 and Level/deferred-leveldown#89.
Closes #491.