Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.

test: make sure destroy() deletes leveldb-only dir #428

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

joyeecheung
Copy link
Contributor

@joyeecheung joyeecheung commented Jan 24, 2018

Discovered in a Node.js CITGM run for nodejs/node#18308:

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1229/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/leveldown_v2_1_1/

The test is asserting that fs.existsSync() which is always false at the moment.

@joyeecheung
Copy link
Contributor Author

joyeecheung commented Jan 24, 2018

cc @rvagg since you are listed as maintainers in lookup.json of the CITGM

@@ -56,7 +56,7 @@ makeTest('test destroy() cleans and removes leveldb-only dir', function (db, t,
db.close(function (err) {
t.notOk(err, 'no error')
leveldown.destroy(location, function () {
t.notOk(fs.existsSync(), 'directory completely removed')
t.notOk(fs.existsSync(location), 'directory completely removed')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ralphtheninja
Copy link
Member

I canceled the OSX builds, hence build failure.

@ralphtheninja ralphtheninja merged commit beaf17a into Level:master Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants