Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement manifest functionality #35

Closed
ralphtheninja opened this issue Jan 29, 2018 · 0 comments · Fixed by #79
Closed

implement manifest functionality #35

ralphtheninja opened this issue Jan 29, 2018 · 0 comments · Fixed by #79
Labels
enhancement New feature or request

Comments

@ralphtheninja
Copy link
Member

ralphtheninja commented Jan 29, 2018

At the moment deferred-leveldown looks to see if the underlying store has .approximateSize() and if so, adds a function so it can be deferred. This is only a temporary solution and we would need something more generic that can defer any method.

see

if (self._db.approximateSize) {
self.approximateSize = function () {
return this._db.approximateSize.apply(this._db, arguments)
}
}

and

if (typeof self._db.approximateSize === 'function') {
self.approximateSize = function () {
this._operations.push({
method: 'approximateSize',
args: arguments
})
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant