Skip to content

Commit 0d38b0b

Browse files
committed
stable version
1 parent b4830fd commit 0d38b0b

File tree

5 files changed

+26
-17
lines changed

5 files changed

+26
-17
lines changed

libs/javax.servlet-api-3.0.1.jar

83.4 KB
Binary file not shown.

libs/jrns-common.jar

1.46 KB
Binary file not shown.

libs/servlet-api-2.5.jar

-103 KB
Binary file not shown.

src/me/salimm/jrns/constants/Constants.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ public interface Constants {
1818
public static final int TYPE_SERVICE_IO_IN = 0;
1919
public static final int TYPE_SERVICE_IO_OUT = 1;
2020

21+
2122
}

src/me/salimm/jrns/db/SQLBasedUtils.java

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java.sql.Connection;
44
import java.sql.ResultSet;
55
import java.sql.SQLException;
6+
import java.sql.Statement;
67
import java.util.ArrayList;
78
import java.util.List;
89

@@ -16,22 +17,29 @@ public class SQLBasedUtils implements DBUtils, Constants {
1617

1718
@Override
1819
public ServiceProviderInfo getServer(Connection conn, int serviceId) throws SQLException {
19-
String sql = "SELECT * from SERVICE_PROVIDER WHERE SID = " + serviceId + " ORDER BY RAND() LIMIT 1;";
20+
String sql = "SELECT * from SERVICE_PROVIDER WHERE SID = " + serviceId + " ORDER BY RANDOM() LIMIT 1;";
2021
ResultSet rs = conn.createStatement().executeQuery(sql);
21-
if (!rs.next())
22+
if (!rs.next()) {
23+
rs.getStatement().close();
2224
return null;
25+
}
26+
ServiceProviderInfo info = new ServiceProviderInfo(rs.getString("URL"), rs.getInt("PORT"), "",
27+
StubEnvType.JAVA);
2328
rs.getStatement().close();
24-
return new ServiceProviderInfo(rs.getString("IP"), rs.getInt("PORT"), rs.getString("NAME"), StubEnvType.JAVA);
29+
return info;
2530
}
2631

2732
@Override
2833
public ServiceProviderInfo getServer(Connection conn, String serviceName) throws SQLException {
29-
String sql = "SELECT * from SERVICE_PROVIDER WHERE NAME = " + serviceName + " ORDER BY RAND() LIMIT 1;";
34+
String sql = "SELECT * from SERVICE_PROVIDER WHERE NAME = '" + serviceName + "' ORDER BY RANDOM() LIMIT 1;";
3035
ResultSet rs = conn.createStatement().executeQuery(sql);
31-
if (!rs.next())
36+
if (!rs.next()) {
37+
rs.getStatement().close();
3238
return null;
39+
}
40+
ServiceProviderInfo info = new ServiceProviderInfo(rs.getString("IP"), rs.getInt("PORT"), "", StubEnvType.JAVA);
3341
rs.getStatement().close();
34-
return new ServiceProviderInfo(rs.getString("IP"), rs.getInt("PORT"), rs.getString("NAME"), StubEnvType.JAVA);
42+
return info;
3543
}
3644

3745
@Override
@@ -53,7 +61,7 @@ public ServiceProviderInfo[] getAllServer(Connection conn, int serviceId) throws
5361
public ServiceProviderInfo[] getAllServer(Connection conn, String serviceName) throws SQLException {
5462
ArrayList<ServiceProviderInfo> list = new ArrayList<ServiceProviderInfo>();
5563

56-
String sql = "SELECT * from SERVICE_PROVIDER WHERE NAME = " + serviceName + ";";
64+
String sql = "SELECT * from SERVICE_PROVIDER WHERE NAME = '" + serviceName + "';";
5765
ResultSet rs = conn.createStatement().executeQuery(sql);
5866
while (rs.next()) {
5967
list.add(new ServiceProviderInfo(rs.getString("IP"), rs.getInt("PORT"), rs.getString("NAME"),
@@ -66,7 +74,7 @@ public ServiceProviderInfo[] getAllServer(Connection conn, String serviceName) t
6674
@Override
6775
public ServiceInfo<?> getServiceInfo(Connection conn, String serviceName)
6876
throws SQLException, ClassNotFoundException {
69-
String sql = "SELECT * from SERVICE WHERE NAME = " + serviceName + "";
77+
String sql = "SELECT * from SERVICE WHERE NAME = '" + serviceName + "'";
7078
ResultSet rs = conn.createStatement().executeQuery(sql);
7179
if (!rs.next())
7280
return null;
@@ -116,12 +124,12 @@ public ServiceInfo<?> getServiceInfo(Connection conn, int serviceId) throws SQLE
116124

117125
@Override
118126
public boolean registerServiceProvider(Connection conn, ServiceInfo<?> service, ServiceProviderInfo provider) {
119-
String sql = "INSERT INTO SERVICE_PROVIDER (SID, URL, PORT) VALUES (" + service.getId() + "" + provider.getIp()
120-
+ "" + provider.getPort() + ");";
121-
ResultSet rs;
127+
String sql = "INSERT INTO SERVICE_PROVIDER (SID, URL, PORT) VALUES (" + service.getId() + ",'"
128+
+ provider.getIp() + "'," + provider.getPort() + ");";
122129
try {
123-
rs = conn.createStatement().executeQuery(sql);
124-
rs.getStatement().close();
130+
Statement stmt = conn.createStatement();
131+
stmt.executeUpdate(sql);
132+
stmt.close();
125133
} catch (SQLException e) {
126134
e.printStackTrace();
127135
return false;
@@ -131,12 +139,12 @@ public boolean registerServiceProvider(Connection conn, ServiceInfo<?> service,
131139

132140
@Override
133141
public boolean removeServiceProvider(Connection conn, ServiceInfo<?> service, ServiceProviderInfo provider) {
134-
String sql = "DELETE FROM TABLE SERVICE_PROVIDER WHERE URL = " + provider.getIp() + " and PORT="
142+
String sql = "DELETE FROM TABLE SERVICE_PROVIDER WHERE URL = '" + provider.getIp() + "' and PORT="
135143
+ provider.getPort() + ";";
136-
ResultSet rs;
137144
try {
138-
rs = conn.createStatement().executeQuery(sql);
139-
rs.getStatement().close();
145+
Statement stmt = conn.createStatement();
146+
stmt.executeUpdate(sql);
147+
stmt.close();
140148
} catch (SQLException e) {
141149
e.printStackTrace();
142150
return false;

0 commit comments

Comments
 (0)