forked from envoyproxy/envoy
-
Notifications
You must be signed in to change notification settings - Fork 0
/
default_header_validator_integration_test.cc
190 lines (164 loc) · 8.49 KB
/
default_header_validator_integration_test.cc
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
#include "test/integration/http_protocol_integration.h"
namespace Envoy {
using DownstreamUhvIntegrationTest = HttpProtocolIntegrationTest;
INSTANTIATE_TEST_SUITE_P(Protocols, DownstreamUhvIntegrationTest,
testing::ValuesIn(HttpProtocolIntegrationTest::getProtocolTestParams(
{Http::CodecType::HTTP1, Http::CodecType::HTTP2,
Http::CodecType::HTTP3},
{Http::CodecType::HTTP1})),
HttpProtocolIntegrationTest::protocolTestParamsToString);
// Without the `uhv_translate_backslash_to_slash` override UHV rejects requests with backslash in
// the path.
TEST_P(DownstreamUhvIntegrationTest, BackslashInUriPathConversionWithUhvOverride) {
config_helper_.addRuntimeOverride("envoy.reloadable_features.uhv_translate_backslash_to_slash",
"false");
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void { hcm.mutable_normalize_path()->set_value(true); });
initialize();
codec_client_ = makeHttpConnection(lookupPort("http"));
// Start the request.
auto response = codec_client_->makeHeaderOnlyRequest(
Http::TestRequestHeaderMapImpl{{":method", "GET"},
{":path", "/path\\with%5Cback%5Cslashes"},
{":scheme", "http"},
{":authority", "host"}});
#ifdef ENVOY_ENABLE_UHV
// By default Envoy disconnects connection on protocol errors
ASSERT_TRUE(codec_client_->waitForDisconnect());
if (downstream_protocol_ != Http::CodecType::HTTP2) {
ASSERT_TRUE(response->complete());
EXPECT_EQ("400", response->headers().getStatusValue());
} else {
ASSERT_TRUE(response->reset());
EXPECT_EQ(Http::StreamResetReason::ConnectionTermination, response->resetReason());
}
#else
waitForNextUpstreamRequest();
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path/with%5Cback%5Cslashes");
// Send a headers only response.
upstream_request_->encodeHeaders(default_response_headers_, true);
ASSERT_TRUE(response->waitForEndStream());
#endif
}
// By default the `uhv_translate_backslash_to_slash` == true and UHV behaves just like legacy path
// normalization.
TEST_P(DownstreamUhvIntegrationTest, BackslashInUriPathConversion) {
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void { hcm.mutable_normalize_path()->set_value(true); });
initialize();
codec_client_ = makeHttpConnection(lookupPort("http"));
// Start the request.
auto response = codec_client_->makeHeaderOnlyRequest(
Http::TestRequestHeaderMapImpl{{":method", "GET"},
{":path", "/path\\with%5Cback%5Cslashes"},
{":scheme", "http"},
{":authority", "host"}});
waitForNextUpstreamRequest();
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path/with%5Cback%5Cslashes");
// Send a headers only response.
upstream_request_->encodeHeaders(default_response_headers_, true);
ASSERT_TRUE(response->waitForEndStream());
}
// By default the `uhv_preserve_url_encoded_case` == true and UHV behaves just like legacy path
// normalization.
TEST_P(DownstreamUhvIntegrationTest, UrlEncodedTripletsCasePreserved) {
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void { hcm.mutable_normalize_path()->set_value(true); });
initialize();
codec_client_ = makeHttpConnection(lookupPort("http"));
// Start the request.
auto response = codec_client_->makeHeaderOnlyRequest(
Http::TestRequestHeaderMapImpl{{":method", "GET"},
{":path", "/path/with%3bmixed%5Ccase%Fesequences"},
{":scheme", "http"},
{":authority", "host"}});
waitForNextUpstreamRequest();
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path/with%3bmixed%5Ccase%Fesequences");
// Send a headers only response.
upstream_request_->encodeHeaders(default_response_headers_, true);
ASSERT_TRUE(response->waitForEndStream());
}
// Without the `uhv_preserve_url_encoded_case` override UHV changes all percent encoded
// sequences to use uppercase characters.
TEST_P(DownstreamUhvIntegrationTest, UrlEncodedTripletsCasePreservedWithUhvOverride) {
config_helper_.addRuntimeOverride("envoy.reloadable_features.uhv_preserve_url_encoded_case",
"false");
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void { hcm.mutable_normalize_path()->set_value(true); });
initialize();
codec_client_ = makeHttpConnection(lookupPort("http"));
// Start the request.
auto response = codec_client_->makeHeaderOnlyRequest(
Http::TestRequestHeaderMapImpl{{":method", "GET"},
{":path", "/path/with%3bmixed%5Ccase%Fesequences"},
{":scheme", "http"},
{":authority", "host"}});
waitForNextUpstreamRequest();
#ifdef ENVOY_ENABLE_UHV
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path/with%3Bmixed%5Ccase%FEsequences");
#else
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path/with%3bmixed%5Ccase%Fesequences");
#endif
// Send a headers only response.
upstream_request_->encodeHeaders(default_response_headers_, true);
ASSERT_TRUE(response->waitForEndStream());
}
// Without the `uhv_allow_malformed_url_encoding` override UHV rejects requests with malformed
// percent encoding.
TEST_P(DownstreamUhvIntegrationTest, MalformedUrlEncodedTripletsRejectedWithUhvOverride) {
config_helper_.addRuntimeOverride("envoy.reloadable_features.uhv_allow_malformed_url_encoding",
"false");
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void { hcm.mutable_normalize_path()->set_value(true); });
initialize();
codec_client_ = makeHttpConnection(lookupPort("http"));
// Start the request.
auto response = codec_client_->makeHeaderOnlyRequest(
Http::TestRequestHeaderMapImpl{{":method", "GET"},
{":path", "/path%Z%30with%XYbad%7Jencoding%A"},
{":scheme", "http"},
{":authority", "host"}});
#ifdef ENVOY_ENABLE_UHV
// By default Envoy disconnects connection on protocol errors
ASSERT_TRUE(codec_client_->waitForDisconnect());
if (downstream_protocol_ != Http::CodecType::HTTP2) {
ASSERT_TRUE(response->complete());
EXPECT_EQ("400", response->headers().getStatusValue());
} else {
ASSERT_TRUE(response->reset());
EXPECT_EQ(Http::StreamResetReason::ConnectionTermination, response->resetReason());
}
#else
waitForNextUpstreamRequest();
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path%Z0with%XYbad%7Jencoding%A");
// Send a headers only response.
upstream_request_->encodeHeaders(default_response_headers_, true);
ASSERT_TRUE(response->waitForEndStream());
#endif
}
// By default the `uhv_allow_malformed_url_encoding` == true and UHV behaves just like legacy path
// normalization.
TEST_P(DownstreamUhvIntegrationTest, MalformedUrlEncodedTripletsAllowed) {
config_helper_.addConfigModifier(
[](envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager&
hcm) -> void { hcm.mutable_normalize_path()->set_value(true); });
initialize();
codec_client_ = makeHttpConnection(lookupPort("http"));
// Start the request.
auto response = codec_client_->makeHeaderOnlyRequest(
Http::TestRequestHeaderMapImpl{{":method", "GET"},
{":path", "/path%Z%30with%XYbad%7Jencoding%"},
{":scheme", "http"},
{":authority", "host"}});
waitForNextUpstreamRequest();
EXPECT_EQ(upstream_request_->headers().getPathValue(), "/path%Z0with%XYbad%7Jencoding%");
// Send a headers only response.
upstream_request_->encodeHeaders(default_response_headers_, true);
ASSERT_TRUE(response->waitForEndStream());
}
} // namespace Envoy