Removed unnecessary entity and renamed some vars.

Author: crsanti

lib/src/baseFormValidation.ts

@@ -62,9 +62,9 @@ export class BaseFormValidation implements FormValidation {
     });
   }
 
-  private addFieldValidation(constraint: string, validationConstraint: FieldValidationConstraint): FormValidation {
+  private addFieldValidation(field: string, validationConstraint: FieldValidationConstraint): FormValidation {
     this.validationEngine.addFieldValidation(
-      constraint,
+      field,
       validationConstraint.validator,
       validationConstraint.eventsFilter,
       validationConstraint.customParams

lib/src/entities.ts

@@ -39,16 +39,14 @@ export interface FormValidationFunction {
   (vm: any): ValidationResult;
 }
 
-export interface SyncValidationFunction {
-  (value: any, vm: any, customParams: any): ValidationResult;
+export interface FieldValidationFunction {
+  (value: any, vm: any, customParams: any): Promise<FieldValidationResult> |ValidationResult;
 }
 
 export interface AsyncFieldValidationFunction {
   (value: any, vm: any, customParams: any): Promise<FieldValidationResult>;
 }
 
-export type FieldValidationFunction = SyncValidationFunction | AsyncFieldValidationFunction;
-
 export interface FieldValidationConstraint {
   validator: FieldValidationFunction;
   eventsFilter?: ValidationEventsFilter;

samples/react/02 QuizForm/src/components/quizForm/validations/quizFormValidation.ts

@@ -1,12 +1,12 @@
 import { FieldValidationResult, createFormValidation } from 'lc-form-validation';
 import { QuizEntity, Question } from '../../../entity/quizEntity';
 
-function isThereAnyQuestionSelected(quiz: QuizEntity) {
+function isAnyQuestionSelected(quiz: QuizEntity) {
   return Object.keys(quiz).some(question => (quiz[question] as Question).isSelected);
 }
 
 function quizValidation(quiz: QuizEntity) {
-  const isQuizPassed = isThereAnyQuestionSelected(quiz);
+  const isQuizPassed = isAnyQuestionSelected(quiz);
   const errorInfo = (isQuizPassed) ? '' : 'Failed';
   const fieldValidationResult: FieldValidationResult = new FieldValidationResult();
   fieldValidationResult.type = 'QUIZ_VALIDATION';
@@ -19,7 +19,7 @@ const quizValidationConstraints = {
   global: [
     quizValidation
   ]
-}
+};
 
 const quizFormValidation = createFormValidation(quizValidationConstraints);