From 1b4de047635f7136ff8f4daf5aca05a1a0a9a000 Mon Sep 17 00:00:00 2001 From: Junbo Wang Date: Fri, 14 Jan 2022 11:12:32 +0800 Subject: [PATCH] Fix swagger correctness: secrets were wrongfully marked as write-only (#17228) * allow accessKeys to be readable * add x-ms-identifiers * remove x-ms-identifier --- .../stable/2021-10-01/signalr.json | 24 ++++--------------- .../stable/2021-10-01/webpubsub.json | 24 ++++--------------- 2 files changed, 8 insertions(+), 40 deletions(-) diff --git a/specification/signalr/resource-manager/Microsoft.SignalRService/stable/2021-10-01/signalr.json b/specification/signalr/resource-manager/Microsoft.SignalRService/stable/2021-10-01/signalr.json index 2e2df3d8edab..05b771eb6b90 100644 --- a/specification/signalr/resource-manager/Microsoft.SignalRService/stable/2021-10-01/signalr.json +++ b/specification/signalr/resource-manager/Microsoft.SignalRService/stable/2021-10-01/signalr.json @@ -1923,38 +1923,22 @@ "primaryKey": { "description": "The primary access key.", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true }, "secondaryKey": { "description": "The secondary access key.", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true }, "primaryConnectionString": { "description": "Connection string constructed via the primaryKey", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true }, "secondaryConnectionString": { "description": "Connection string constructed via the secondaryKey", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true } } }, diff --git a/specification/webpubsub/resource-manager/Microsoft.SignalRService/stable/2021-10-01/webpubsub.json b/specification/webpubsub/resource-manager/Microsoft.SignalRService/stable/2021-10-01/webpubsub.json index f010b3ca4d39..dad3011b9e43 100644 --- a/specification/webpubsub/resource-manager/Microsoft.SignalRService/stable/2021-10-01/webpubsub.json +++ b/specification/webpubsub/resource-manager/Microsoft.SignalRService/stable/2021-10-01/webpubsub.json @@ -2377,38 +2377,22 @@ "primaryKey": { "description": "The primary access key.", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true }, "secondaryKey": { "description": "The secondary access key.", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true }, "primaryConnectionString": { "description": "Connection string constructed via the primaryKey", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true }, "secondaryConnectionString": { "description": "Connection string constructed via the secondaryKey", "type": "string", - "x-ms-secret": true, - "x-ms-mutability": [ - "create", - "update" - ] + "x-ms-secret": true } } },