From 6be689d3d4597f1b09c4fc9e568d467abe697ddd Mon Sep 17 00:00:00 2001 From: Cat Core <34719527+thecatcore@users.noreply.github.com> Date: Sat, 10 Feb 2024 22:27:50 +0100 Subject: [PATCH] Fix crash when executing commands from signs (#156) * fix legacy-fabric-permissions-api-v1 * Fix inner class field name * bump permissions-api-v1 version --------- Co-authored-by: Luke Schwager --- gradle.properties | 2 +- .../fabric/mixin/permission/SignBlockEntity_2Mixin.java | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/gradle.properties b/gradle.properties index 3a733ea29..502937d43 100644 --- a/gradle.properties +++ b/gradle.properties @@ -16,7 +16,7 @@ legacy-fabric-keybindings-api-v1.version = 1.0.1 legacy-fabric-lifecycle-events-v1.version = 1.0.1 legacy-fabric-logger-api-v1.version = 1.0.4 legacy-fabric-networking-api-v1.version = 2.0.0 -legacy-fabric-permissions-api-v1.version = 1.0.0 +legacy-fabric-permissions-api-v1.version = 1.0.1 legacy-fabric-registry-sync-api-v1.version = 2.1.0 legacy-fabric-rendering-api-v1.version = 1.0.0 legacy-fabric-resource-loader-v1.version = 2.1.0 diff --git a/legacy-fabric-permissions-api-v1/1.8.9/src/main/java/net/legacyfabric/fabric/mixin/permission/SignBlockEntity_2Mixin.java b/legacy-fabric-permissions-api-v1/1.8.9/src/main/java/net/legacyfabric/fabric/mixin/permission/SignBlockEntity_2Mixin.java index 4fb9c12b1..54d763384 100644 --- a/legacy-fabric-permissions-api-v1/1.8.9/src/main/java/net/legacyfabric/fabric/mixin/permission/SignBlockEntity_2Mixin.java +++ b/legacy-fabric-permissions-api-v1/1.8.9/src/main/java/net/legacyfabric/fabric/mixin/permission/SignBlockEntity_2Mixin.java @@ -28,14 +28,13 @@ @Mixin(targets = "net/minecraft/block/entity/SignBlockEntity$2") public abstract class SignBlockEntity_2Mixin implements PermissibleCommandSource { - @SuppressWarnings("ShadowTarget") @Final @Dynamic @Shadow - PlayerEntity editor; + PlayerEntity field_9859; @Override public boolean hasPermission(String perm) { - return ((PermissibleCommandSource) this.editor).hasPermission(perm); + return ((PermissibleCommandSource) this.field_9859).hasPermission(perm); } }