Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ts support (needs updated vsc-leetcode-cli) #573

Merged
merged 3 commits into from
Jun 27, 2020

Conversation

nathanesau
Copy link
Contributor

@nathanesau nathanesau commented Jun 13, 2020

Related Issue: #560

This PR contains the required changes for vscode-leetcode to enable typescript support.

This PR depends on leetcode-tools/leetcode-cli#45. The two PR should be merged together.

With those changes, here is a screenshot of working ts support:

demo

solirpa
solirpa previously approved these changes Jun 17, 2020
@jdneo
Copy link
Member

jdneo commented Jun 18, 2020

I'll merge this PR after the cli get released. Probably this weekend

jdneo
jdneo previously approved these changes Jun 27, 2020
@jdneo jdneo force-pushed the vscode-leetcode-560 branch from 2eca270 to 9972542 Compare June 27, 2020 07:13
@jdneo jdneo closed this Jun 27, 2020
@jdneo jdneo reopened this Jun 27, 2020
@jdneo
Copy link
Member

jdneo commented Jun 27, 2020

Thank you @nathanesau.

Merged with some small changes.

@jdneo jdneo merged commit 7705ce7 into LeetCode-OpenSource:master Jun 27, 2020
@jdneo jdneo added this to the 0.17.0 milestone Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants