-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play move with the highest lower confidence bound #817
Conversation
I think you'll need something similar to this in meson.build:
|
Oh, boost isn't used anywhere. Somehow it works on my machine. Probably no point in adding it just for this one function call. |
TODO: Fix sorting in VerboseStats to use ratio.
Optimum based on clop at 800 nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, excited to see it works so well!
return -1e6f + visits; | ||
} | ||
|
||
auto stddev = std::sqrt(GetVariance(1.0f) / visits); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this is the standard error (standard deviation divided by sqrt(N)). Maybe stderr
is a better variable name.
Or is this the standard deviation of something in another context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of the estimated distribution for the mean which has this standard deviation. Standard error seems to be correct too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that seems logical, I didn't think about it that way :).
Takes multivisit into account.
Some testing at high nodes, nothing conclusive. TC 30+0.5s. Ryzen 1700X and RTX2080. SF with 16 threads.
|
Quick patch to fix appveyor builds: borg323@bad4503 |
TC 4.8s/game+0.02s/move (~900 nodes/move)
TC 17.04s/game+0.071s/move (~6000 nodes/move)
|
As far as I know, this is still relevant, and not solved by time manager or so. Might be a candidate for @kiudee tuning it once updated, and merged if useful. |
Closing this for a combination of several reasons:
|
Same as leela-zero/leela-zero#2290. Some features still missing from the LZ PR:
minimum visit ratioand avoiding pruning of the best LCB move in time management.