Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sheet-specific override of Bounding Box Compatibility Setting for Module Authors #132

Open
kgar opened this issue Dec 14, 2024 · 1 comment

Comments

@kgar
Copy link

kgar commented Dec 14, 2024

Hello, I am the dev for Tidy 5e Sheets. Recently, I've been working on an overhaul for my info cards, and as a result, when Tidy sheets pop out with the Bounding Box compat setting turned on, the popout window includes the empty space where the info card would normally appear:

image

image

This makes sense, based on PopOut!'s compatibility for the dnd5e default sheet vertical tab strip which sits outside the regular bounding box.

Would it be possible to update the bounding box code if (game && game.settings.get("popout", "trueBoundingBox")) { so that a sheet-specific attribute or class could override the default setting? This could allow for GMs with a mix and match of sheet types. Their default sheets would work with the bounding box while Tidy sheets selectively prevent the recursive bounding box calculation.

Maybe something like:

if (game && game.settings.get("popout", "trueBoundingBox") && !app.element[0].matches('[data-popout-suppress-recursive-bounding-box]')) {

At least, this would allow module authors like me to be able to disable the feature for alternate sheets without requiring an all-or-nothing client setting for a user with multiple different types of sheets.

On my end, I already have a compatibility layer for when PopOut! is active, so I can hook into my own sheets and apply any attributes to support this type of override feature.

@kgar kgar changed the title Feature: Sheet-specific override of Bounding Box Compatibility Setting Feature: Sheet-specific override of Bounding Box Compatibility Setting for Module Authors Dec 14, 2024
@Zimnior12
Copy link

Yeah, would love to see this fixed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants