You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I am the dev for Tidy 5e Sheets. Recently, I've been working on an overhaul for my info cards, and as a result, when Tidy sheets pop out with the Bounding Box compat setting turned on, the popout window includes the empty space where the info card would normally appear:
This makes sense, based on PopOut!'s compatibility for the dnd5e default sheet vertical tab strip which sits outside the regular bounding box.
Would it be possible to update the bounding box code if (game && game.settings.get("popout", "trueBoundingBox")) { so that a sheet-specific attribute or class could override the default setting? This could allow for GMs with a mix and match of sheet types. Their default sheets would work with the bounding box while Tidy sheets selectively prevent the recursive bounding box calculation.
Maybe something like:
if (game && game.settings.get("popout", "trueBoundingBox") && !app.element[0].matches('[data-popout-suppress-recursive-bounding-box]')) {
At least, this would allow module authors like me to be able to disable the feature for alternate sheets without requiring an all-or-nothing client setting for a user with multiple different types of sheets.
On my end, I already have a compatibility layer for when PopOut! is active, so I can hook into my own sheets and apply any attributes to support this type of override feature.
The text was updated successfully, but these errors were encountered:
kgar
changed the title
Feature: Sheet-specific override of Bounding Box Compatibility Setting
Feature: Sheet-specific override of Bounding Box Compatibility Setting for Module Authors
Dec 14, 2024
Hello, I am the dev for Tidy 5e Sheets. Recently, I've been working on an overhaul for my info cards, and as a result, when Tidy sheets pop out with the Bounding Box compat setting turned on, the popout window includes the empty space where the info card would normally appear:
This makes sense, based on PopOut!'s compatibility for the dnd5e default sheet vertical tab strip which sits outside the regular bounding box.
Would it be possible to update the bounding box code
if (game && game.settings.get("popout", "trueBoundingBox")) {
so that a sheet-specific attribute or class could override the default setting? This could allow for GMs with a mix and match of sheet types. Their default sheets would work with the bounding box while Tidy sheets selectively prevent the recursive bounding box calculation.Maybe something like:
if (game && game.settings.get("popout", "trueBoundingBox") && !app.element[0].matches('[data-popout-suppress-recursive-bounding-box]')) {
At least, this would allow module authors like me to be able to disable the feature for alternate sheets without requiring an all-or-nothing client setting for a user with multiple different types of sheets.
On my end, I already have a compatibility layer for when PopOut! is active, so I can hook into my own sheets and apply any attributes to support this type of override feature.
The text was updated successfully, but these errors were encountered: