Prevent skewing on selected edit marker #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly set box-sizing to prevent the selected edit marker from being skewed when using other common libraries.
|
Thanks @JasonSanford for the assistance with this topic. This is my first PR for Leaflet, so please let me know if there's something I've missed. |
|
Sorry for not accepting this earlier I missed it! |
jacobtoye
added a commit
that referenced
this pull request
Jan 24, 2015
…ected Prevent skewing on selected edit marker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
box-sizing: border-box;is a fairly common pattern these days. Specifically, projects like Bootstrap and Mapbox.js specifically setbox-sizing: border-box;, which results in the marker being skewed when incorporating them and Leaflet.draw into your project. It would be best to protect against skewed draggable markers by explicitly settingbox-sizing: content-box;.Skewed selected edit marker:
Corrected selected edit marker:
