Skip to content

Conversation

@nyg
Copy link

@nyg nyg commented Sep 21, 2025

Here are the changes I did:

  • Used sortpom to sort the elements within the POM file. Apache actually recommends a specific order for POM elements, see here.
  • Updated scm and issueManagement URLs, replaced jiaqi by LeMyst.
  • Removed a duplicated guava dependency. I checked by running mvn dependency:tree | grep guava and only the correct version is returned.
  • Created properties for each dependency versions.
  • Removed the parent POM. As it belongs to jiaqi and he's probably not going to update it anymore, I think it's better to remove it. Java version is now Java 17 instead of Java 8.

What I also recommend is that you:

  • Change the value of <groupId> (e.g. to something like org.LeMyst) so you can remove -lemyst suffix in version number.
  • Remove ciManagement if it's not used anymore.

@LeMyst
Copy link
Owner

LeMyst commented Sep 25, 2025

Hi @nyg
Thanks for your PR,
Sorry for the time this take.
I think it will be good this time.

@nyg
Copy link
Author

nyg commented Sep 25, 2025

@LeMyst no problem :) I updated my PR once more, let me know if there's anything else I should do.

@LeMyst LeMyst merged commit 4faba76 into LeMyst:main Sep 25, 2025
5 checks passed
@nyg nyg deleted the clean_pom branch September 25, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants