Added a workaround for the empty requests issue. This is still pending to be fixed, but for now the server is once again stable.

LeHack · LeHack · commit 9c366f224f50 · 2016-01-09T09:18:20.000+01:00
Updated the example form.pl, to show a full range of possibilities.
diff --git a/src/Worker.cpp b/src/Worker.cpp
@@ -41,13 +41,20 @@ void Worker::handle_request() {
         // TODO not sure if necessary
         if(errno == EINTR){
             this->logger->info("Recv() interrupted by signal");
+            free(request);
             return;
         }
         return_code = HTTP_BAD_REQUEST;
         data = dHandler.get_error_file(return_code, "Empty request received");
     }
     else {
         std::string req_str = std::string(request);
+        if (req_str.length() == 0) {
+            this->logger->warn("Empty request received, ignoring");
+            free(request);
+            return;
+        }
+
         BasicHTTP::request req = httpHandler.parse_request(req_str);
 
         if (req.valid) {
diff --git a/t/cgi/form.pl b/t/cgi/form.pl
@@ -32,13 +32,18 @@ sub main {
         $output = "Top of $tod to you $name! It is very nice to meet you :)";
     }
 
-    # first print the cookie
-    my $cookie;
-    if ($name) {
-        $cookie = bake_cookie($name);
+    # prepare the cookie
+    my $cookie = '';
+    if ($cgi->param('reset')) {
+        $cookie = drop_cookie();
+        $output = "Goodbye $name :)";
     }
+    else {
+        $cookie = ($name ? bake_cookie($name) : '');
+    }
+
     # then the rest
-    print_out($cookie, $output, $footer);
+    printf get_template(), $cookie, $output, $footer;
 
     return;
 }
@@ -50,37 +55,39 @@ sub fetch_from_cookie {
 
 sub bake_cookie {
     my ($name) = @_;
-    return "Set-Cookie: name=$name\n";
+    return "Set-Cookie: name=$name; HttpOnly";
 }
 
-sub print_out {
-    my ($cookie, $output, $footer) = @_;
-
-    $cookie ||= '';
+sub drop_cookie {
+    my ($name) = @_;
+    return bake_cookie("deleted") . "; MaxAge=0; expires=Thu, 01 Jan 1970 00:00:00 GMT";
+}
 
-    print << "EOF";
+sub get_template {
+    my $template = << "EOF";
 HTTP/1.x 200 OK
 Content-Type: text/html; charset=UTF-8;
-$cookie
+%s
 
 <html>
     <head>
         <title>Created by form.pl</title>
         <link rel="stylesheet" type="text/css" href="/t/css/form.css">
     </head>
     <body>
-        <h2>$output</h2>
+        <h2>%s</h2>
         <p class="content">
             <img src="/t/images/hello.png" alt="hello"></img></br>
-            <a href="/t/form.html">Back to the form</a>
-            <a href="/t/cgi/form.pl">Show with no input params</a>
+            <a href="/t/form.html">Back to the form</a><br/>
+            <a href="/t/cgi/form.pl">Show with no input params</a><br/>
+            <a href="/t/cgi/form.pl?reset=1">Drop cookie</a>
         </p>
-        <p class="footer">$footer</p>
+        <p class="footer">%s</p>
     </body>
 </html>
 EOF
 
-    return;
+    return $template;
 }
 
 main();
