Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Problems #21

Open
thoth-amon opened this issue Feb 12, 2021 · 6 comments
Open

Dark Mode Problems #21

thoth-amon opened this issue Feb 12, 2021 · 6 comments

Comments

@thoth-amon
Copy link

Version 0.9.1 AppImage

Am using KDE with a dark theme. The text in the URL bar stays black, so you can't read it or see what you are typing in it. The forward button, back buttons and the add tab button are also dark coloured.

I don't know whether this is of any help but I've attached versions of the buttons in a colour visible on both dark and light backgrounds Colour #777777

arrow-back
arrow-forward
new-tab

@LeFroid
Copy link
Owner

LeFroid commented Feb 13, 2021

Thank you for reporting this. Do you mind sharing which dark theme you are using? I would like to test on my machine to make sure an appropriate fix is implemented.

@thoth-amon
Copy link
Author

Breeze Dark. It looks like this for me

Screenshot_20210213_194253

@LeFroid
Copy link
Owner

LeFroid commented Feb 26, 2021

Working on this now. The icons will render in white if the local environment has a dark theme, otherwise they use the default gray icons. The text in the URL bar should be easier to read as well.

I would like to update the green color of the HTTPS scheme and icon, so they pop out more, and probably update the magnifying glass icon + the checkmark in the ad block icon to a whiter color.

I am open to feedback and will keep you posted on further updates to the UI

@thoth-amon
Copy link
Author

Thanks looks much better now. I looked round for some other things that don't look in the dark theme.

  • The outline for check boxes doesn't show, which makes them more difficult to select.

  • A lot of the icons in the menus (File, Edit etc) are black so they don't show up well.

  • Navigation Arrows in the Manage Bookmark section need the same change as in the main window.

  • The autofill website suggestions is dark
    image

  • The editing Test Script box highlight makes the text unreadable. Also black icon for Save.
    image

  • The view source box has a blue font colour, which is hard to read
    image

@LeFroid
Copy link
Owner

LeFroid commented Feb 28, 2021

Thanks for the feedback! I think you'll find most of these things looking better with the latest commit.
Couple of points/questions-

  • Can you share a screenshot of the checkboxes?
  • Are you using a custom icon set? The menu icons all appeared in white on my machine using Breeze Dark. Although I tested with a native build and not AppImage.

@thoth-amon
Copy link
Author

Sorry, the icons were my fault! I was using a light icon set. I switched to Breeze Dark and it worked fine in the AppImage.

Screenshot of the checkboxes:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants