fix: enforce quorum registration on churn #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypatil12
added a commit
that referenced
this pull request
May 1, 2025
NOTE: #464 was merged to wrong target **Motivation:** It is possible to break the `maxOperatorCount` invariant by doing the following: Let's assume there are two quorums, 1 and 2, with a `maxOperatorCount` of 2. 1. Alice & Bob register for quorum 1 2. Bob registers for quorum 2 3. Bob deregisters from quorum 1, Charlie enters 4. Quorum 1 Members: Alice/Charlie. Quorum 2 members: Bob 5. Eve creates a churn registration that exits Bob. Quorum 1 has 3 members. This works just fine since we allow a churn to occur if the `operatorToKick` is registered to the AVS (not the quorum): https://github.com/Layr-Labs/eigenlayer-middleware/blob/f5adbcac55d9336cd646ce71bc467aa7e20f1a12/src/SlashingRegistryCoordinator.sol#L405-L408 Although this assumes that the `churnApprover` is buggy, we should still be enforcing that you are churning a user if they are registered for the quorum. **Modifications:** Require that the `operatorToKick` is registered for the quorum. **Result:** Stricter churn guarantees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It is possible to break the
maxOperatorCountinvariant by doing the following:Let's assume there are two quorums, 1 and 2, with a
maxOperatorCountof 2.operatorToKickis registered to the AVS (not the quorum):eigenlayer-middleware/src/SlashingRegistryCoordinator.sol
Lines 405 to 408 in f5adbca
Although this assumes that the
churnApproveris buggy, we should still be enforcing that you are churning a user if they are registered for the quorum.Modifications:
Require that the
operatorToKickis registered for the quorum.Result:
Stricter churn guarantees.