Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ecdsa service manager #234

Merged
merged 14 commits into from
May 1, 2024
Merged

feat: ecdsa service manager #234

merged 14 commits into from
May 1, 2024

Conversation

stevennevins
Copy link
Collaborator

No description provided.

@stevennevins stevennevins self-assigned this Apr 26, 2024
@stevennevins stevennevins marked this pull request as ready for review April 26, 2024 15:58
Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very reasonable, looks clean, nice work 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really understand how any of this is ECDSA specific

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming was to signal that it's associated with the ECDSAStakeRegistry

@stevennevins stevennevins merged commit 9968b1d into dev May 1, 2024
3 checks passed
@stevennevins stevennevins deleted the feat/ecdsa-service-manager branch May 1, 2024 14:52
aroralanuk added a commit to hyperlane-xyz/hyperlane-monorepo that referenced this pull request May 9, 2024
### Description

- Implements `IServiceManager` for the `ECDSAServiceManagerBase` which
has a single quorum
- `HyperlaneServiceManager` (HSM), the main AVS contract for
registering/deregistering operators and enrolling/unenrolling into
challengers
- the HSM has a mutable slasher so that once the EL slasher is live, we
can set it for your AVS too to enable freezing operators.
- EnumerableMapEnrollment for a enumerable map of enrollment statuses
for each operator and challenger

Update: I switched the ECDSAServiceManager i had written earlier to
steven's PR here:
Layr-Labs/eigenlayer-middleware#234. The
differences are:
 - events for (de)registering

Notes

- `hardhat yarn` tries looking for all imports (including the ones from
submodules) as npm libraries , eg. @eigenlayer/core.

### Drive-by changes

- none

### Related issues

- fixes #3590,

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants