Skip to content

fix(audit): assert redistribution recipient != burn address #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0xClandestine merged 1 commit into from
Jun 12, 2025
Merged

fix(audit): assert redistribution recipient != burn address #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/contracts/core/AllocationManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,10 @@ contract AllocationManager is
require(params.length == redistributionRecipients.length, InputArrayLengthMismatch());
require(_avsRegisteredMetadata[avs], NonexistentAVSMetadata());
for (uint256 i = 0; i < params.length; i++) {
require(redistributionRecipients[i] != address(0), InputAddressZero());
_createOperatorSet(avs, params[i], redistributionRecipients[i]);
address recipient = redistributionRecipients[i];
require(recipient != address(0), InputAddressZero());
require(recipient != DEFAULT_BURN_ADDRESS, InvalidRedistributionRecipient());
_createOperatorSet(avs, params[i], recipient);
}
}

Expand Down
2 changes: 2 additions & 0 deletions src/contracts/interfaces/IAllocationManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ interface IAllocationManagerErrors {
error InvalidAVSRegistrar();
/// @dev Thrown when an invalid strategy is provided.
error InvalidStrategy();
/// @dev Thrown when an invalid redistribution recipient is provided.
error InvalidRedistributionRecipient();

/// Caller

Expand Down
19 changes: 17 additions & 2 deletions src/test/unit/AllocationManagerUnit.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ contract AllocationManagerUnitTests is EigenLayerUnitTestSetup, IAllocationManag
/// Constants
/// -----------------------------------------------------------------------

address internal constant DEFAULT_BURN_ADDRESS = 0x00000000000000000000000000000000000E16E4;

/// NOTE: Raising these values directly increases cpu time for tests.
uint internal constant FUZZ_MAX_ALLOCATIONS = 8;
uint internal constant FUZZ_MAX_STRATS = 8;
Expand Down Expand Up @@ -3745,8 +3747,6 @@ contract AllocationManagerUnitTests_removeStrategiesFromOperatorSet is Allocatio
contract AllocationManagerUnitTests_createOperatorSets is AllocationManagerUnitTests {
using ArrayLib for *;

address internal constant DEFAULT_BURN_ADDRESS = 0x00000000000000000000000000000000000E16E4;

function testRevert_createOperatorSets_InvalidOperatorSet() public {
cheats.prank(defaultAVS);
cheats.expectRevert(InvalidOperatorSet.selector);
Expand Down Expand Up @@ -3838,6 +3838,21 @@ contract AllocationManagerUnitTests_createRedistributingOperatorSets is Allocati
);
}

function testRevert_createRedistributingOperatorSets_InvalidRedistributionRecipient(Randomness r) public rand(r) {
address avs = r.Address();
address[] memory redistributionRecipients = new address[](1);
redistributionRecipients[0] = DEFAULT_BURN_ADDRESS;

cheats.prank(avs);
allocationManager.updateAVSMetadataURI(avs, "https://example.com");

cheats.prank(avs);
cheats.expectRevert(InvalidRedistributionRecipient.selector);
allocationManager.createRedistributingOperatorSets(
avs, CreateSetParams(defaultOperatorSet.id, defaultStrategies).toArray(), redistributionRecipients
);
}

function testFuzz_createRedistributingOperatorSets_Correctness(Randomness r) public rand(r) {
address avs = r.Address();
uint numOpSets = r.Uint256(1, FUZZ_MAX_OP_SETS);
Expand Down