feat: require avs register metadata in allocation manager

Author: bowenli86

src/contracts/core/AllocationManager.sol

@@ -256,6 +256,8 @@ contract AllocationManager is
     ) external onlyWhenNotPaused(PAUSED_OPERATOR_SET_REGISTRATION_AND_DEREGISTRATION) checkCanCall(operator) {
         // Check that the operator exists
         require(delegation.isOperator(operator), InvalidOperator());
+        // Check that the AVS exists and has registered metadata
+        require(_avsRegisteredMetadata[params.avs], InvalidAVSWithNoMetadataRegistered());
 
         for (uint256 i = 0; i < params.operatorSetIds.length; i++) {
             // Check the operator set exists and the operator is not currently registered to it
@@ -282,6 +284,8 @@ contract AllocationManager is
     ) external onlyWhenNotPaused(PAUSED_OPERATOR_SET_REGISTRATION_AND_DEREGISTRATION) {
         // Check that the caller is either authorized on behalf of the operator or AVS
         require(_checkCanCall(params.operator) || _checkCanCall(params.avs), InvalidCaller());
+        // Check that the AVS exists and has registered metadata
+        require(_avsRegisteredMetadata[params.avs], InvalidAVSWithNoMetadataRegistered());
 
         for (uint256 i = 0; i < params.operatorSetIds.length; i++) {
             // Check the operator set exists and the operator is registered to it
@@ -324,6 +328,10 @@ contract AllocationManager is
 
     /// @inheritdoc IAllocationManager
     function updateAVSMetadataURI(address avs, string calldata metadataURI) external checkCanCall(avs) {
+        if (!_avsRegisteredMetadata[avs]) {
+            _avsRegisteredMetadata[avs] = true;
+        }
+
         emit AVSMetadataURIUpdated(avs, metadataURI);
     }
 

src/contracts/core/AllocationManagerStorage.sol

@@ -43,6 +43,10 @@ abstract contract AllocationManagerStorage is IAllocationManager {
     /// Note: if set to 0, defaults to the AVS's address
     mapping(address avs => IAVSRegistrar) internal _avsRegistrar;
 
+    /// @dev Lists the AVSs who has registered metadata and claimed itself as an AVS
+    /// @notice bool is not used and if always true if the avs has registered metadata
+    mapping(address avs => bool) internal _avsRegisteredMetadata;
+
     /// @dev Lists the operator set ids an AVS has created
     mapping(address avs => EnumerableSet.UintSet) internal _operatorSets;
 
@@ -102,5 +106,5 @@ abstract contract AllocationManagerStorage is IAllocationManager {
      * variables without shifting down storage in the inheritance chain.
      * See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps
      */
-    uint256[37] private __gap;
+    uint256[36] private __gap;
 }

src/contracts/interfaces/IAllocationManager.sol

@@ -23,6 +23,8 @@ interface IAllocationManagerErrors {
 
     /// @dev Thrown when an invalid operator is provided.
     error InvalidOperator();
+    /// @dev Thrown when an invalid avs whose metadata is not registered is provided.
+    error InvalidAVSWithNoMetadataRegistered();
     /// @dev Thrown when an operator's allocation delay has yet to be set.
     error UninitializedAllocationDelay();
     /// @dev Thrown when attempting to slash an operator when they are not slashable.