refactor: small cleanup

refactor small cleanup

chore: `forge fmt`

fix: `getQueuedWithdrawals` + test

fix: add constructor back

test: `totalQueued` > `withdrawal.strategies.length`

test(wip): `completeQueuedWithdrawals`

currently failing

fix: effectBlock

test(wip): @8sunyuan patch

fix: one flaky test

fix: second flaky test

Author: 0xClandestine

src/contracts/core/AllocationManager.sol

@@ -63,6 +63,7 @@ contract AllocationManager is
         // Check that the operator set exists and the operator is registered to it
         OperatorSet memory operatorSet = OperatorSet(avs, params.operatorSetId);
         bool isOperatorSlashable = _isOperatorSlashable(params.operator, operatorSet);
+        require(params.strategies.length == params.wadsToSlash.length, InputArrayLengthMismatch());
         require(_operatorSets[operatorSet.avs].contains(operatorSet.id), InvalidOperatorSet());
         require(isOperatorSlashable, OperatorNotSlashable());
 

src/contracts/core/DelegationManager.sol

@@ -942,7 +942,7 @@ contract DelegationManager is
             for (uint256 j; j < withdrawals[i].strategies.length; ++j) {
                 shares[i][j] = SlashingLib.scaleForCompleteWithdrawal({
                     scaledShares: withdrawals[i].scaledShares[j],
-                    slashingFactor: slashingFactors[i]
+                    slashingFactor: slashingFactors[j]
                 });
             }
         }

src/contracts/interfaces/IAllocationManager.sol

@@ -4,7 +4,6 @@ pragma solidity >=0.5.0;
 import {OperatorSet} from "../libraries/OperatorSetLib.sol";
 import "./IPauserRegistry.sol";
 import "./IStrategy.sol";
-import "./ISignatureUtils.sol";
 import "./IAVSRegistrar.sol";
 
 interface IAllocationManagerErrors {
@@ -213,7 +212,7 @@ interface IAllocationManagerEvents is IAllocationManagerTypes {
     event StrategyRemovedFromOperatorSet(OperatorSet operatorSet, IStrategy strategy);
 }
 
-interface IAllocationManager is ISignatureUtils, IAllocationManagerErrors, IAllocationManagerEvents {
+interface IAllocationManager is IAllocationManagerErrors, IAllocationManagerEvents {
     /**
      * @dev Initializes the initial owner and paused status.
      */

src/test/unit/AllocationManagerUnit.t.sol

@@ -613,6 +613,15 @@ contract AllocationManagerUnitTests_SlashOperator is AllocationManagerUnitTests
         allocationManager.slashOperator(defaultAVS, _randSlashingParams(random().Address(), 0));
     }
 
+    function test_revert_InputArrayLengthMismatch() public {
+        SlashingParams memory slashingParams = _randSlashingParams(defaultOperator, 0);
+        slashingParams.strategies = slashingParams.strategies.setLength(2);
+
+        cheats.prank(defaultAVS);
+        cheats.expectRevert(InputArrayLengthMismatch.selector);
+        allocationManager.slashOperator(defaultAVS, slashingParams);
+    }
+
     function test_revert_StrategiesMustBeInAscendingOrder() public {
         IStrategy[] memory strategies = new IStrategy[](3);
         strategies[0] = IStrategy(address(3));