Skip to content

Commit 57b6aed

Browse files
committed
refactor: Bn254CertificateVerifierUnitTests (#1476)
**Motivation:** Match `Bn254CertificateVerifier` tests with styling. **Modifications:** - Add `isNonsignerCached` view function - Make `trySignatureVerification` _public_ - Add a contract per function under test - Use Multichain deployer and mocks properly **Result:** Cleaner tests
1 parent cfba4fe commit 57b6aed

File tree

18 files changed

+2682
-585
lines changed

18 files changed

+2682
-585
lines changed

pkg/bindings/BN254CertificateVerifier/binding.go

Lines changed: 114 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/BN254CertificateVerifierStorage/binding.go

Lines changed: 139 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/ECDSACertificateVerifier/binding.go

Lines changed: 95 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/ECDSACertificateVerifierStorage/binding.go

Lines changed: 125 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/ECDSATableCalculator/binding.go

Lines changed: 580 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/ECDSATableCalculatorBase/binding.go

Lines changed: 496 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/IBN254CertificateVerifier/binding.go

Lines changed: 139 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/IECDSACertificateVerifier/binding.go

Lines changed: 125 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/bindings/OperatorTableUpdater/binding.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

script/deploy/devnet/mutlichain/deploy_multichain_l2.s.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ contract DeployMultichain_L2 is Script, Test {
6262
operatorTableUpdaterImplementation = new OperatorTableUpdater(
6363
bn254CertificateVerifier, IECDSACertificateVerifier(address(emptyContract)), "0.0.1"
6464
);
65-
bn254CertificateVerifierImplementation = new BN254CertificateVerifier(operatorTableUpdater);
65+
bn254CertificateVerifierImplementation = new BN254CertificateVerifier(operatorTableUpdater, "1.0.0");
6666

6767
// Third, upgrade the proxies to point to the new implementations
6868
proxyAdmin.upgrade(

0 commit comments

Comments
 (0)