Skip to content

Commit 478eb77

Browse files
committed
test: fork test fix 2
1 parent a10cab3 commit 478eb77

File tree

5 files changed

+19
-13
lines changed

5 files changed

+19
-13
lines changed

script/deploy/devnet/deploy_from_scratch.s.sol

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,8 @@ contract DeployFromScratch is Script, Test {
344344
StrategyFactory.initialize.selector,
345345
executorMultisig,
346346
0, // initial paused status
347-
IBeacon(strategyBeacon)
347+
IBeacon(strategyBeacon),
348+
IBeacon(address(0))
348349
)
349350
);
350351

script/releases/TestUtils.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -967,7 +967,7 @@ library TestUtils {
967967
StrategyFactory strategyFactory
968968
) internal {
969969
vm.expectRevert(errInit);
970-
strategyFactory.initialize(address(0), 0, UpgradeableBeacon(address(0)));
970+
strategyFactory.initialize(address(0), 0, UpgradeableBeacon(address(0)), UpgradeableBeacon(address(0)));
971971
}
972972

973973
/// multichain/

src/contracts/strategies/StrategyFactory.sol

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,15 @@ contract StrategyFactory is StrategyFactoryStorage, OwnableUpgradeable, Pausable
3232
function initialize(
3333
address _initialOwner,
3434
uint256 _initialPausedStatus,
35-
IBeacon _strategyBeacon
35+
IBeacon _strategyBeacon,
36+
IBeacon _durationVaultBeacon
3637
) public virtual initializer {
3738
_transferOwnership(_initialOwner);
3839
_setPausedStatus(_initialPausedStatus);
3940
_setStrategyBeacon(_strategyBeacon);
41+
if (address(_durationVaultBeacon) != address(0)) {
42+
_setDurationVaultBeacon(_durationVaultBeacon);
43+
}
4044
}
4145

4246
/// @notice Deploy a new StrategyBase contract for the ERC20 token, using a beacon proxy

src/test/integration/IntegrationDeployer.t.sol

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,6 @@ abstract contract IntegrationDeployer is ExistingDeploymentParser {
276276
_deployProxies(); // deploy proxies (if undeployed)
277277
_deployImplementations();
278278
_upgradeProxies();
279-
strategyFactory.setDurationVaultBeacon(durationVaultBeacon);
280279
cheats.stopPrank();
281280
}
282281

@@ -460,7 +459,12 @@ abstract contract IntegrationDeployer is ExistingDeploymentParser {
460459

461460
allocationManager.initialize({initialPausedStatus: 0});
462461

463-
strategyFactory.initialize({_initialOwner: executorMultisig, _initialPausedStatus: 0, _strategyBeacon: strategyBeacon});
462+
strategyFactory.initialize({
463+
_initialOwner: executorMultisig,
464+
_initialPausedStatus: 0,
465+
_strategyBeacon: strategyBeacon,
466+
_durationVaultBeacon: durationVaultBeacon
467+
});
464468

465469
rewardsCoordinator.initialize({
466470
initialOwner: executorMultisig,
@@ -469,10 +473,6 @@ abstract contract IntegrationDeployer is ExistingDeploymentParser {
469473
_activationDelay: 0,
470474
_defaultSplitBips: 5000
471475
});
472-
473-
cheats.startPrank(executorMultisig);
474-
strategyFactory.setDurationVaultBeacon(durationVaultBeacon);
475-
cheats.stopPrank();
476476
}
477477

478478
/// @dev Deploy a strategy and its underlying token, push to global lists of tokens/strategies, and whitelist

src/test/unit/StrategyFactoryUnit.t.sol

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ contract StrategyFactoryUnitTests is EigenLayerUnitTestSetup {
7878
new TransparentUpgradeableProxy(
7979
address(strategyFactoryImplementation),
8080
address(eigenLayerProxyAdmin),
81-
abi.encodeWithSelector(StrategyFactory.initialize.selector, initialOwner, initialPausedStatus, strategyBeacon)
81+
abi.encodeWithSelector(
82+
StrategyFactory.initialize.selector, initialOwner, initialPausedStatus, strategyBeacon, durationVaultBeacon
83+
)
8284
)
8385
)
8486
);
85-
86-
strategyFactory.setDurationVaultBeacon(durationVaultBeacon);
8787
}
8888

8989
function test_initialization() public view {
@@ -117,7 +117,8 @@ contract StrategyFactoryUnitTests is EigenLayerUnitTestSetup {
117117
strategyFactory.initialize({
118118
_initialOwner: initialOwner,
119119
_initialPausedStatus: initialPausedStatus,
120-
_strategyBeacon: strategyBeacon
120+
_strategyBeacon: strategyBeacon,
121+
_durationVaultBeacon: durationVaultBeacon
121122
});
122123
}
123124

0 commit comments

Comments
 (0)