chore: update BN254CertificateVerifier (#1447)

**Motivation:**

Minor updates for `BN254CertificateVerifier` 

**Modifications:**

- Update interface
- Use types for `OperatorTableUpdater`
- Remove ownable

**Result:**

Minor Updates

Author: ypatil12

foundry.toml

@@ -123,6 +123,7 @@
 [profile.coverage.fuzz]
     optimizer = false
     runs = 1
+    gas_limit = "18446744073709551615" # u64::MAX
 
 [profile.medium.fuzz]
     optimizer = false

src/contracts/multichain/BN254CertificateVerifier.sol

@@ -2,15 +2,11 @@
 pragma solidity ^0.8.27;
 
 import "@openzeppelin-upgrades/contracts/proxy/utils/Initializable.sol";
-import "@openzeppelin-upgrades/contracts/access/OwnableUpgradeable.sol";
 
 import {BN254} from "../libraries/BN254.sol";
 import {Merkle} from "../libraries/Merkle.sol";
 import {OperatorSet} from "../libraries/OperatorSetLib.sol";
 
-import "../interfaces/IBN254TableCalculator.sol";
-import "../interfaces/IBN254CertificateVerifier.sol";
-import "../interfaces/IBaseCertificateVerifier.sol";
 import "./BN254CertificateVerifierStorage.sol";
 
 /**
@@ -19,7 +15,7 @@ import "./BN254CertificateVerifierStorage.sol";
  * @dev This contract uses BN254 curves for signature verification and
  *      caches operator information for efficient verification
  */
-contract BN254CertificateVerifier is Initializable, OwnableUpgradeable, BN254CertificateVerifierStorage {
+contract BN254CertificateVerifier is Initializable, BN254CertificateVerifierStorage {
     using Merkle for bytes;
     using BN254 for BN254.G1Point;
 
@@ -37,32 +33,21 @@ contract BN254CertificateVerifier is Initializable, OwnableUpgradeable, BN254Cer
      * @notice Restricts access to the operator table updater
      */
     modifier onlyTableUpdater() {
-        require(msg.sender == _operatorTableUpdater, OnlyTableUpdater());
+        require(msg.sender == address(operatorTableUpdater), OnlyTableUpdater());
         _;
     }
 
     /**
      * @notice Constructor for the certificate verifier
      * @dev Disables initializers to prevent implementation initialization
-     * @param __operatorTableUpdater Address authorized to update operator tables
+     * @param _operatorTableUpdater Address authorized to update operator tables
      */
     constructor(
-        address __operatorTableUpdater
-    ) BN254CertificateVerifierStorage(__operatorTableUpdater) {
+        IOperatorTableUpdater _operatorTableUpdater
+    ) BN254CertificateVerifierStorage(_operatorTableUpdater) {
         _disableInitializers();
     }
 
-    /**
-     * @notice Initialize the contract
-     * @param __owner The initial owner of the contract
-     */
-    function initialize(
-        address __owner
-    ) external initializer {
-        __Ownable_init();
-        _transferOwnership(__owner);
-    }
-
     ///@inheritdoc IBaseCertificateVerifier
     function getOperatorSetOwner(
         OperatorSet memory operatorSet
@@ -374,12 +359,4 @@ contract BN254CertificateVerifier is Initializable, OwnableUpgradeable, BN254Cer
         bytes32 operatorSetKey = operatorSet.key();
         return _operatorSetInfos[operatorSetKey][referenceTimestamp];
     }
-
-    /**
-     * @notice Get the current operator table updater address
-     * @return The operator table updater address
-     */
-    function getOperatorTableUpdater() external view returns (address) {
-        return _operatorTableUpdater;
-    }
 }

src/contracts/multichain/BN254CertificateVerifierStorage.sol

@@ -2,6 +2,7 @@
 pragma solidity ^0.8.27;
 
 import {OperatorSet} from "../libraries/OperatorSetLib.sol";
+import "../interfaces/IOperatorTableUpdater.sol";
 import "../interfaces/IBN254TableCalculator.sol";
 import "../interfaces/IBN254CertificateVerifier.sol";
 import "../interfaces/IBaseCertificateVerifier.sol";
@@ -15,12 +16,12 @@ abstract contract BN254CertificateVerifierStorage is IBN254CertificateVerifier {
     /// @dev Basis point unit denominator for division
     uint256 internal constant BPS_DENOMINATOR = 10_000;
 
-    // Immutables - None in this case, but could be added if needed
-
-    // Mutatables
+    // Immutables
 
     /// @dev The address that can update operator tables
-    address immutable _operatorTableUpdater;
+    IOperatorTableUpdater public immutable operatorTableUpdater;
+
+    // Mutatables
 
     /// @dev Mapping from operatorSet key to owner address
     mapping(bytes32 => address) internal _operatorSetOwners;
@@ -32,19 +33,18 @@ abstract contract BN254CertificateVerifierStorage is IBN254CertificateVerifier {
     mapping(bytes32 => uint32) internal _latestReferenceTimestamps;
 
     /// @dev Mapping from operatorSet key to reference timestamp to operator set info
-    mapping(bytes32 => mapping(uint32 => IBN254TableCalculatorTypes.BN254OperatorSetInfo)) internal _operatorSetInfos;
+    mapping(bytes32 => mapping(uint32 => BN254OperatorSetInfo)) internal _operatorSetInfos;
 
     /// @dev Mapping from operatorSet key to reference timestamp to operator index to operator info
     /// This is used to cache operator info that has been proven against a tree root
-    mapping(bytes32 => mapping(uint32 => mapping(uint256 => IBN254TableCalculatorTypes.BN254OperatorInfo))) internal
-        _operatorInfos;
+    mapping(bytes32 => mapping(uint32 => mapping(uint256 => BN254OperatorInfo))) internal _operatorInfos;
 
     // Construction
 
     constructor(
-        address __operatorTableUpdater
+        IOperatorTableUpdater _operatorTableUpdater
     ) {
-        _operatorTableUpdater = __operatorTableUpdater;
+        operatorTableUpdater = _operatorTableUpdater;
     }
 
     /**

src/test/integration/tests/ALM_Multi.t.sol

@@ -69,7 +69,7 @@ contract Integration_ALM_Multi is IntegrationCheckUtils {
 
     /// Reduce fuzz runs because this test is thiccc:
     ///
-    /// forge-config: default.fuzz.runs = 5
+    /// forge-config: default.fuzz.runs = 3
     /// forge-config: forktest.fuzz.runs = 3
     function test_Multi(uint24 _r) public rand(_r) {
         // Do 20 iterations

src/test/unit/BN254CertificateVerifierUnit.t.sol

@@ -8,6 +8,7 @@ import "src/contracts/libraries/BN254.sol";
 import "src/contracts/libraries/Merkle.sol";
 import "src/contracts/libraries/OperatorSetLib.sol";
 import "src/contracts/multichain/BN254CertificateVerifier.sol";
+import "src/contracts/interfaces/IOperatorTableUpdater.sol";
 import "src/contracts/interfaces/IBN254CertificateVerifier.sol";
 import "src/contracts/interfaces/IBN254TableCalculator.sol";
 import "src/contracts/interfaces/ICrossChainRegistry.sol";
@@ -48,11 +49,10 @@ contract BN254CertificateVerifierTest is Test {
         testOperatorSet.id = 1;
 
         // Deploy implementation
-        BN254CertificateVerifier implementation = new BN254CertificateVerifier(tableUpdater);
+        BN254CertificateVerifier implementation = new BN254CertificateVerifier(IOperatorTableUpdater(tableUpdater));
 
         // Deploy proxy and initialize
-        ERC1967Proxy proxy =
-            new ERC1967Proxy(address(implementation), abi.encodeWithSelector(BN254CertificateVerifier.initialize.selector, owner));
+        ERC1967Proxy proxy = new ERC1967Proxy(address(implementation), "");
 
         verifier = BN254CertificateVerifier(address(proxy));