Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we remove verification when reading from caches #145

Open
samlaf opened this issue Sep 21, 2024 · 5 comments
Open

can we remove verification when reading from caches #145

samlaf opened this issue Sep 21, 2024 · 5 comments

Comments

@samlaf
Copy link
Collaborator

samlaf commented Sep 21, 2024

Noticed that GET requests on my local devnet are taking ~500ms to complete when using a redis cache
image

Have not profiled but my guess is that verification is taking most of this time.

@bxue-l2 suggested that we might be able to remove the verification done everytime we read from the cache. When verification is enabled, we verify responses from the disperser before populating the redis cache, so it seems redundant to verify blobs queried from redis?

@epociask wdyt?

@epociask
Copy link
Collaborator

seems like a legitimate optimization - assuming that blobs are verified before insertion to cache

@epociask
Copy link
Collaborator

feel free to assign to me if no one else is interested

@epociask
Copy link
Collaborator

epociask commented Oct 2, 2024

@samlaf @bxue-l2 think we shoudl still keep this given the recent issue that celo had where blob contents being read from cache were incorrectly transformed. If the verification was disabled then the chain's derivation would've halted

@samlaf
Copy link
Collaborator Author

samlaf commented Oct 2, 2024

@epociask why were they improperly transformed? Bug in our client?

@epociask
Copy link
Collaborator

@samlaf @bxue-l2 if we provide a knob for this we can add a dangerous env type to enable this. There are pretty severe security degradations when using this mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants