Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stats profiling in favor of prometheus #113

Open
epociask opened this issue Sep 5, 2024 · 1 comment · May be fixed by #182
Open

Remove stats profiling in favor of prometheus #113

epociask opened this issue Sep 5, 2024 · 1 comment · May be fixed by #182

Comments

@epociask
Copy link
Collaborator

epociask commented Sep 5, 2024

No description provided.

@samlaf
Copy link
Collaborator

samlaf commented Oct 14, 2024

Update here after chatting with @epociask: seems like prometheus doesn't make it easy to Get the value of some counter/gauge (unlike VictoriaMetrics, see here). Furthermore the way they propose (using https://github.com/prometheus/client_model) is deprecated... so not sure what's the recommended way to do this in 2024.

Another way is to use some internal atomic variable, which we increment and use in code, and then wrap that and expose it to prometheus via a CounterFunc (see here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants