Added tls support for validating certificates #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation made several months ago at Lawouach@9ffee99 works properly when turning on wss:// URLs but fails when trying to turn on server cert validation. This fixes the issues with cert validation - I made this change on my day job's internal Gitlab, and I'm making a PR back into the public repo to contribute the fix back.
auvipy
reviewed
Jul 2, 2024
auvipy
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation made several months ago at 9ffee99 works properly when turning on wss:// URLs but fails when trying to turn on server cert validation.
This fixes the issues with cert validation - I made this change on my day job's internal Gitlab, and I'm making a PR back into the public repo to contribute the fix back.