-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Malformed integer encodings in EmberPlusView 2.4 #96
Comments
Hello, Best regards, |
It looks like this error has only been introduced in the Ember+ Viewer, which uses a separate C# implementation of the Ember+ library. We are going to fix this within the next days and release a new version. |
We have fixed this encoding issue in the Viewer and will publish a new release beginning of next week. The libraries in this repository should not be affected by this issue. |
Fixed with EmberPlus Viewer v2.40.0.24 available on the releases page. |
The initial getDirectory issued by Ember+ Viewer 2.4 has the following form:
60 80 6b 80 a0 80 62 80 a0 04 02 02 00 20 a1 04 02 02 ff ff 00 00 00 00 00 00 00 00
where I have maked the two integers in question as bold. The first is the command type 32 = getDirectory, and the second is the field mask -1 = all. The first nine bits of the first integer are all zero, and the first nine bits of the second integer are all one.
The Ember+ documentation (and the ASN.1 spec) clearly states:
Special care must be taken by the encoder to comply to rule [X.690 8.3.2]: the first 9 bits of the encoded integer value must not be the same.
Moreover, an example of how to encode -1 is listed in the ember+ documentation stating it should be "FF".
EmberPlusView 1.6 does not have this problem.
The text was updated successfully, but these errors were encountered: