Uploaders - Refactor and fixes #5478

pxpm · 2024-03-21T11:06:57Z

This PR aims to fix and at the same time refactor uploaders and it's related validation classes.

Since launched some issues were identified for example the lack of validation support inside repeatables, or the tight coupling between an "ajax uploader" and a "dropzone uploader", that would prevent us from adding other types of ajax uploads like EasyMDE. Issues in dropzone validation .. etc.

There is a companion PR to this one in: https://github.com/Laravel-Backpack/PRO/pull/232

tabacitu · 2024-03-25T02:22:42Z

Please please PLEASE start writing a title and description for every PR you create Pedro. It takes 2-3 minutes, man. And it helps YOU and the rest of the team understand what's happening there.

I swear I will start closing PRs that are not descriptive. You've been warned.

pxpm · 2024-04-04T09:27:40Z

Check #5484 before merging this.

karandatwani92 · 2024-04-05T10:12:51Z

Hey @pxpm

I tested fields of uploaders-test-branch. I'm facing many issues with it:

1) Base64 Image CRUD::field('image')->type('image'); results✔️(fixed in demo branch):
2) Dropezone not working without validation, results:❌

3) EasyMDE
Setting custom destination & path breaks it.❌

CRUD::field('easymde')->type('easymde')->withFiles([
  'disk' => 'public',
  'path' => 'destinations'
]);

4) Upload Multiple IDK exactly when, but some combination empty the array and removes the past stored items of another Multiple Upload field.❌

I'm considering testing subfields after the Green Flag on the above direct-use fields.

pxpm · 2024-04-05T11:46:57Z

I am sorry @karandatwani92

But I am not able to reproduce any of the issue you mentioned:

I think I made the mistake of giving the test branch I used, I should have just let you guys create your own tests. It was intended to be used aa a guide, the branch it's not working AFAIK, it's missing routes for example.

I think in 1) it's clearly missing ->withFiles(). 🤷

I couldn't reproduce any of the other bugs you mentioned. The image of the easy mde in the screenshot is in:

CRUD::field('easymde')->type('easymde')->withFiles([
            'path' => 'test',
        ]);

Let me know if I can help you with something.

karandatwani92 · 2024-04-07T14:34:49Z

Hey @pxpm, I'm facing the same issues even with a fresh installation.
PLUS, I found one more bug:

Using an upload field with ['disk'=>'public', 'path'=>'destination'] attributes appends the path to the stored path(old file on different path), which breaks the URL. It is not supposed to append anything to the DB stored path/value. The deletion of the old file is working fine in this case.

pxpm · 2024-04-10T09:20:00Z

@karandatwani92 test issues:

Dropzone don't work without defining validation.
EasyMDE appends an extra slash (/) when defining the upload with some custom path and that breaks file url.
Single file upload behaves different than multiple file. Single file upload builds the file using the disk and prefix, while multiple uploads use the file as is in the database.
I am not sure this one is related with this PR specifically. As far as I can see, this PR does not touch Uploaders.php class, so it does not change the retrieve behavior, nor the changes done in upload.blade.php touch any of this bit.
Looking at upload.blade.php history https://github.com/Laravel-Backpack/CRUD/blame/main/src/resources/views/crud/fields/upload.blade.php I don't see any changes that would have changed this behavior, so I can assume that's something @karandatwani92 found while testing this, but it's not specifically related to this changes, so I opened [WIP] upload vs upload_multiple file display inconsistent behavior. #5491 for further discussion on the topic.

karandatwani92 · 2024-04-13T15:10:39Z

Hey @pxpm

The above bugs are fixed✅. Now I started testing subfields under repeatable and there is an issue:

Suppose we created two rows and saved them. Go to Edit and Reorder - (It breaks saving: causes validation error)❌

pxpm · 2024-04-17T15:33:24Z

Hey @pxpm

The above bugs are fixed✅. Now I started testing subfields under repeatable and there is an issue:

Suppose we created two rows and saved them. Go to Edit and Reorder - (It breaks saving: causes validation error)❌

Thanks @karandatwani92 haven't spotted that. 🙏 nice catch!

I've just pushed fixes both in this PR and in PRO PR to address that issue.
Please note that I rebased both branches, so if you have any troubles with a git pull, please just delete the local branch and download a new copy.

Thanks again 🙏

karandatwani92 · 2024-04-18T09:20:32Z

Hey @pxpm

New Issue: Create new, edit, and save without changes(validation error even when the file is already attached):

karandatwani92 · 2024-05-24T15:51:04Z

New Bugs:

Message for Default Validation Error is missing. (See the difference.)
If I switch the repeatable row position, the subfield upload value stays, but the file gets deleted.

pxpm · 2024-05-24T15:55:42Z

1 is not a bug, in the demo app mimetypes is not added to translations, it comes by default with Laravel since Laravel 9 if I am not mistaken, we never bothered adding it to the demo because we don't use it.

2 might be a bug, I am not sure if I have a test case covering that, if not I will add one and evaluate that scenario.

Thanks.

pxpm · 2024-05-26T08:55:35Z

@karandatwani92 I've identified the issue you reported in 2 and added a test alongside with the fix for it. 🙏

karandatwani92 · 2024-05-28T10:38:56Z

Hey @pxpm

I tested it, and it is working completely fine. Please continue with the media uploader and we'll re-test again.

[ci skip] [skip ci]

src/app/Library/CrudPanel/CrudField.php

* add method to get ajax uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * use an abstract class * wip * Apply fixes from StyleCI [ci skip] [skip ci] * refactor uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * refactor rules * Apply fixes from StyleCI [ci skip] [skip ci] * move ajax to PRO, cleanup * Apply fixes from StyleCI [ci skip] [skip ci] * make attributes available for all subfields * fix tests * wip * Apply fixes from StyleCI [ci skip] [skip ci] * upload multiple and upload properly working 🙏 * fixes * Apply fixes from StyleCI [ci skip] [skip ci] * allow the configuration of valueWithoutPath call. * fix valid upload inside repeatables * Apply fixes from StyleCI [ci skip] [skip ci] * fix condition * cleanup * fix * Apply fixes from StyleCI [ci skip] [skip ci] * fix use case for enabling validation after entry is created * Apply fixes from StyleCI [ci skip] [skip ci] * dont save array keys * fix ajax validation * fix validation messages * Apply fixes from StyleCI [ci skip] [skip ci] * fixes ValidUpload * Apply fixes from StyleCI [ci skip] [skip ci] * dont json encode if casted in the model * Apply fixes from StyleCI [ci skip] [skip ci] * fix previous file identification in repeatable * Apply fixes from StyleCI [ci skip] [skip ci] * fix getting values * Apply fixes from StyleCI [ci skip] [skip ci] * add fake fields support * Apply fixes from StyleCI [ci skip] [skip ci] * wip add uploaders tests * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * add pro columns * fix test suite * fix tests * ffix tests * remove unused test views * add uploaders to test coverage * Apply fixes from StyleCI [ci skip] [skip ci] * add coverage folder to gitignore * make tests run faster by not reloading db when not necessary * add coverage to validation tests * add fake tests to uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * add more tests * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * add more upload assets * fixes * Apply fixes from StyleCI [ci skip] [skip ci] * fix single file * Apply fixes from StyleCI [ci skip] [skip ci] * add image column * fix tests * Apply fixes from StyleCI [ci skip] [skip ci] * remove hardcoded macro names * Apply fixes from StyleCI [ci skip] [skip ci] * remove double loop, fix single file uploader * Apply fixes from StyleCI [ci skip] [skip ci] * use a big increments and unsigned for primary key * handle pivot file deletion * Apply fixes from StyleCI [ci skip] [skip ci] * register events for relation models * Apply fixes from StyleCI [ci skip] [skip ci] * fix typo * Apply fixes from StyleCI [ci skip] [skip ci] * fix relationship uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * update temporary time key * save objects in the macro --------- Co-authored-by: StyleCI Bot <bot@styleci.io>

* Uploaders - Refactor and fixes (#5478) * add method to get ajax uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * use an abstract class * wip * Apply fixes from StyleCI [ci skip] [skip ci] * refactor uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * refactor rules * Apply fixes from StyleCI [ci skip] [skip ci] * move ajax to PRO, cleanup * Apply fixes from StyleCI [ci skip] [skip ci] * make attributes available for all subfields * fix tests * wip * Apply fixes from StyleCI [ci skip] [skip ci] * upload multiple and upload properly working 🙏 * fixes * Apply fixes from StyleCI [ci skip] [skip ci] * allow the configuration of valueWithoutPath call. * fix valid upload inside repeatables * Apply fixes from StyleCI [ci skip] [skip ci] * fix condition * cleanup * fix * Apply fixes from StyleCI [ci skip] [skip ci] * fix use case for enabling validation after entry is created * Apply fixes from StyleCI [ci skip] [skip ci] * dont save array keys * fix ajax validation * fix validation messages * Apply fixes from StyleCI [ci skip] [skip ci] * fixes ValidUpload * Apply fixes from StyleCI [ci skip] [skip ci] * dont json encode if casted in the model * Apply fixes from StyleCI [ci skip] [skip ci] * fix previous file identification in repeatable * Apply fixes from StyleCI [ci skip] [skip ci] * fix getting values * Apply fixes from StyleCI [ci skip] [skip ci] * add fake fields support * Apply fixes from StyleCI [ci skip] [skip ci] * wip add uploaders tests * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * add pro columns * fix test suite * fix tests * ffix tests * remove unused test views * add uploaders to test coverage * Apply fixes from StyleCI [ci skip] [skip ci] * add coverage folder to gitignore * make tests run faster by not reloading db when not necessary * add coverage to validation tests * add fake tests to uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * add more tests * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * add more upload assets * fixes * Apply fixes from StyleCI [ci skip] [skip ci] * fix single file * Apply fixes from StyleCI [ci skip] [skip ci] * add image column * fix tests * Apply fixes from StyleCI [ci skip] [skip ci] * remove hardcoded macro names * Apply fixes from StyleCI [ci skip] [skip ci] * remove double loop, fix single file uploader * Apply fixes from StyleCI [ci skip] [skip ci] * use a big increments and unsigned for primary key * handle pivot file deletion * Apply fixes from StyleCI [ci skip] [skip ci] * register events for relation models * Apply fixes from StyleCI [ci skip] [skip ci] * fix typo * Apply fixes from StyleCI [ci skip] [skip ci] * fix relationship uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * update temporary time key * save objects in the macro --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * trigger testing forkflow on PR * Clean up uploaders (#5725) * wip * clean up * add get uploadedFilesFromRequest to clean up uploaders * Apply fixes from StyleCI [ci skip] [skip ci] * fix type cast * add summernote uploader * update summernote * add summernote * add more test assets --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * allow datatable url configuration (#5713) * use next branch for basset * require alpha version * bump basset version * Lifecycle hooks for CRUD operations (#5687) * wip * Apply fixes from StyleCI [ci skip] [skip ci] * tidy up * Apply fixes from StyleCI [ci skip] [skip ci] * panel hooks * Apply fixes from StyleCI [ci skip] [skip ci] * refactoring :broom * finish implementing hooks * Apply fixes from StyleCI [ci skip] [skip ci] * refactoring hooks * Apply fixes from StyleCI [ci skip] [skip ci] * add hook to delete * allow empty parameters * wip --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * "Agnostic" filters - decouple filters from datatables (#5714) * wip * wip * Apply fixes from StyleCI [ci skip] [skip ci] * wip * Apply fixes from StyleCI [ci skip] [skip ci] * remove filters navbar component --------- Co-authored-by: StyleCI Bot <bot@styleci.io> * bump basset version * Update composer.json * Apply fixes from StyleCI [ci skip] [skip ci] * datatable component (#5688) Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Cristian Tabacitu <cristian.tabacitu@digitallyhappy.com> * move the list heading to the datatable component (#5808) * add Datagrid and Datalist components (#5810) Co-authored-by: StyleCI Bot <bot@styleci.io> * Form component (no ajax form) (#5814) Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Cristian Tabacitu <cristian.tabacitu@digitallyhappy.com> * dataform component fixes (#5816) Co-authored-by: StyleCI Bot <bot@styleci.io> * Added general chip blade file and chip widget (#5815) * Fix Form issues, Add *name* argument to forms (#5817) Co-authored-by: StyleCI Bot <bot@styleci.io> * Drop support for Laravel 10 and 11 (#5819) * Fix hooks at setup level (#5818) Co-authored-by: StyleCI Bot <bot@styleci.io> * install dev-next version of generators * require basset beta version (#5821) * fix scripts on table * fix the keyboard shortcuts on forms * ensure proper crud identification * fix hooks * fix crud field javacript issue * pass the form id to form content * add error page translations * fix export buttons * wip * wip * wip * map the ui files * fix table without export buttons * always focus on error field * delete button redirect * Apply fixes from StyleCI [ci skip] [skip ci] * Fix padding in name * Fix checkbox padding * Background of select2 * multiple fixes * fix form error highlight * wip * Add toggle to JSON * allow user to choose locale and timezone * fixes bulk actions * fix the filter navbar * fix line buttons dropdown * wip * wip * wip * wip * wip * DataFormModal component (#5863) Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Cristian Tabacitu <cristian.tabacitu@digitallyhappy.com> Co-authored-by: Cristian Tăbăcitu <cristitabacitu@gmail.com> * wip * wip * wip * Save action classes (#5878) Enable the usage of classes to describe the save actions. This allow more flexibility and easy to extend and/or configure behaviour. * add cancel button option to modal form (#5881) * fix problem with checklist_dependency field in Update operation * fix indentation * Update src/app/Console/Commands/Install.php * Update composer.json --------- Co-authored-by: Pedro Martins <pxpm88@gmail.com> Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: jcastroa87 <jcastroa87@gmail.com> Co-authored-by: zachweix <zachweix@users.noreply.github.com>

pxpm mentioned this pull request Mar 21, 2024

[WIP] add method to get ajax uploaders #5440

Closed

pxpm changed the title ~~WIP~~ Uploaders - Refactor and fixes Apr 3, 2024

pxpm assigned pxpm, karandatwani92 and jcastroa87 Apr 3, 2024

pxpm added Bug Priority: MUST labels Apr 3, 2024

pxpm mentioned this pull request Apr 4, 2024

Image field and HasTraslation trait issue #5484

Closed

pxpm mentioned this pull request Apr 10, 2024

[WIP] upload vs upload_multiple file display inconsistent behavior. #5491

Open

pxpm force-pushed the fix-uploaders branch from bc6aec7 to 381bf4e Compare April 17, 2024 10:55

karandatwani92 mentioned this pull request May 20, 2024

[BUG] ValidUploadMultiple - False validation while updating Laravel-Backpack/community-forum#983

Open

karandatwani92 removed their assignment May 20, 2024

pxpm force-pushed the fix-uploaders branch from 74c0205 to 45eb69c Compare May 21, 2024 10:12

pxpm mentioned this pull request May 24, 2024

CkEditor(Wysiwyg) file upload Laravel-Backpack/community-forum#641

Closed

pxpm force-pushed the fix-uploaders branch from 1e63f4f to 010dfbf Compare June 17, 2024 18:08

pxpm mentioned this pull request Jun 20, 2024

[2.0] Refactoring, adding tests, cleanup Laravel-Backpack/medialibrary-uploaders#34

Merged

pxpm mentioned this pull request Jul 8, 2024

[Bug] CRUD Repeatable field with sub field image. Use withFiles param path broken file after update model. #5549

Open

StyleCIBot and others added 3 commits October 8, 2024 11:59

Apply fixes from StyleCI

f15888c

[ci skip] [skip ci]

wip

8215e8d

Apply fixes from StyleCI

25c1c5e

[ci skip] [skip ci]

pxpm force-pushed the fix-uploaders branch from 97c9ac2 to 25c1c5e Compare October 8, 2024 10:59

update temporary time key

a99cd51

pxpm changed the base branch from main to v7 October 9, 2024 13:39

tabacitu reviewed Nov 7, 2024

View reviewed changes

src/app/Library/CrudPanel/CrudField.php Outdated Show resolved Hide resolved

save objects in the macro

17f353b

tabacitu approved these changes Nov 7, 2024

View reviewed changes

tabacitu assigned tabacitu and unassigned pxpm and jcastroa87 Nov 7, 2024

tabacitu merged commit 7bf60ea into next Nov 7, 2024
8 checks passed

tabacitu deleted the fix-uploaders branch November 7, 2024 13:42

tabacitu mentioned this pull request Nov 7, 2024

v7 - Next CRUD Version #5715

Merged

2 tasks

backpack-ai-bot bot mentioned this pull request Dec 6, 2024

[Bug] Repeatable field delete images on update operation #5728

Open

Uploaders - Refactor and fixes #5478

Uploaders - Refactor and fixes #5478

Uh oh!

Conversation

pxpm commented Mar 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tabacitu commented Mar 25, 2024

Uh oh!

pxpm commented Apr 4, 2024

Uh oh!

karandatwani92 commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pxpm commented Apr 5, 2024

Uh oh!

karandatwani92 commented Apr 7, 2024

Uh oh!

pxpm commented Apr 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karandatwani92 commented Apr 13, 2024

Uh oh!

pxpm commented Apr 17, 2024

Uh oh!

karandatwani92 commented Apr 18, 2024

Uh oh!

karandatwani92 commented May 24, 2024

Uh oh!

pxpm commented May 24, 2024

Uh oh!

pxpm commented May 26, 2024

Uh oh!

karandatwani92 commented May 28, 2024

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pxpm commented Mar 21, 2024 •

edited

Loading

karandatwani92 commented Apr 5, 2024 •

edited

Loading

pxpm commented Apr 10, 2024 •

edited

Loading