Quest: Convert WOTG: Knot Quite There

[commandobill]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Extracted Knot Quite There quest from NPC luas. I did not change any of the current implementation.

Steps to test these changes

!completequest 7 18
!completemission 5 1
Follow the guide on bg or ffxiclopedia

[zach2good]

Hi there, given that we can't trust previous quest implementations for multiple reasons (they're half-done, they're straight up wrong, they're guessed, they're based entirely on incomplete wiki articles, etc.) it would be much preferred if you could do this work based on retail captures, for which I think there are a few for this quest line.

Sadly, we also can't trust the wikis blindly anymore either, since there are bad actors messing with entries for entirely unknown reasons, and they're pretty much a guide for players to complete each quest with as few steps as possible - skipping over optional and step dialog for all the NPCs involved.

The fear is that if this is converted without having been compared closely to retail captures, it'll be forever marked as "complete", and the chances of someone going through these quests with a fine tooth comb during some sort of audit are infinitesimally small.

If that's a bit much for now, then I'd push for coming up with a new tag instead of -- + Converted, to signify that this was a 1-for-1 conversion form the old code: -- + Partial conversion. TODO: This needs completing with retail caps, etc.

[commandobill]

It's not too much. There are a couple captures I see. I'll review and update today.

[commandobill]

Ok, so today actually meant in a week or so. Anyways, I updated the code based off:
Siknoz Capture 2024
Siknoz Video 2024

Admittedly there was only one part that I didn't get to work and that was the default text of "Door_Acolyte_Hostel_down" What is currently in the code and also what was captured does not say "The door appears to be locked..." so I left it out.

[zach2good]

Admittedly there was only one part that I didn't get to work and that was the default text of "Door_Acolyte_Hostel_down" What is currently in the code and also what was captured does not say "The door appears to be locked..." so I left it out.

I don't understand? What does the capture say? Set that as the default text unless it gets changed while this quest is active

[commandobill]

The capture says:

[16:59:23] [ID View] INCOMING < NPC Chat (0x036): NPC: 17162705 (Door:Acolyte Hostel), Message: 11344
[16:59:23] The door appears to be locked...

But that Message is:

I would rather it say nothing then to have it say that message. I'm sure the dats have just been updated since the capture.

[commandobill]

I have added the default text per the latest game version.

[github-actions]

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

[commandobill]

Anything else missing here? I fixed the above comments.

[claywar]

Hello! I ran some comparisons against a previous capture, and there's one item I'd like to call out. The prevZone check may not be accurate, since Siknoz's cap also received the onZoneIn event after coming from Northern San'doria [S]

[commandobill]

Thanks for taking a look! I'll review and make updates

[github-actions]

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

[commandobill]

I watched every capture I could and all of them required the zone from E Ron. Here's the one from Siknoz showing he didn't get the onzonein when he used the book: https://youtu.be/G4lRA62oF-E?si=3UjlEOSUlLTZrKQ1&t=804 If you could share what you saw it would help.