[WIP][core] Dummy character system#608
Closed
zach2good wants to merge 1 commit into
Closed
Conversation
4 tasks
zach2good
commented
Aug 16, 2021
Comment on lines
313
to
320
Contributor
Author
There was a problem hiding this comment.
TODO: What is the performance penalty here, probably pretty bad...
Contributor
Author
There was a problem hiding this comment.
Could we store all of these in a separate object? ie: CCharEntity has a member: std::unique_ptr<CPacketListContainer> which we populate on CCharEntity contruction, but we set as nullptr for dummies. Think pImp pattern?
zach2good
force-pushed
the
dummy_system
branch
from
00a558a to
3d70678
Compare
Contributor
Author
|
Don't think I ever want this to make it into the actual codebase. Will save the patch and write an article about it |
Contributor
Author
|
Article, linked from the development wiki page: |
The-Aerec
added a commit
to The-Aerec/LSB
that referenced
this pull request
Nov 7, 2022
Adjusts mobType bits as well as addresses mobwsprep function.
|
it will be merg to master banch? |
Contributor
Author
|
No, this was just a proof of concept, it'll never be merged into master/base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concept
I affirm: