Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestBaseUrl can't be undefined #29

Merged
merged 2 commits into from
Sep 22, 2019
Merged

requestBaseUrl can't be undefined #29

merged 2 commits into from
Sep 22, 2019

Conversation

Lakitna
Copy link
Owner

@Lakitna Lakitna commented Sep 21, 2019

Closes #26

  • Tests
  • Documentation
  • Type definitions
  • Ready for merge

@Lakitna
Copy link
Owner Author

Lakitna commented Sep 21, 2019

Ready for self-review

@Lakitna Lakitna changed the title Added string validation & tests requestBaseUrl can't be undefined Sep 21, 2019
@Lakitna Lakitna merged commit a5a0671 into develop Sep 22, 2019
@Lakitna Lakitna mentioned this pull request Oct 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't requestBaseUrl be undefined?
1 participant
@Lakitna