LibWeb: Make WebGLRenderingContextBase derive from PlatformObject #6992
+160
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those do not need to accessible outside of WebGL code as they are just helper functions.
This resolves a bunch of FIXMEs and removes a bunch sketchy raw pointers and hacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a bunch of FIXMEs, removes a bunch of raw pointers and sketchy hacks. There's quite a high chance I messed something up with the WEB_PLATFORM_OBJECT and GC_DECLARE_ALLOCATOR as I'm not sure if I understand them entirely correctly, so sorry in advance :^).