LibMedia+LibWeb: Update the duration of an element based on media data #6945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaggy1024
force-pushed
the
extend-media-duration-from-frames
branch
from
1658fae to
4e8eb6d
Compare
Zaggy1024
changed the title
gmta
reviewed
Nov 27, 2025
The default value of the duration of HTMLMediaElement is NaN according to spec, so we need to make sure that we don't try to paint a timeline with a current position of NaN.
Zaggy1024
force-pushed
the
extend-media-duration-from-frames
branch
from
4e8eb6d to
d997651
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to fully play files that have a duration smaller than the total duration of all frames in the file.
It's currently not possible to seek past the duration, I'll have to have a look if that's something the spec talks about.