Skip to content

Conversation

@tete17
Copy link
Contributor

@tete17 tete17 commented Nov 25, 2025

This MR achieves 3 things:

  • Re-imports the imported WebCryptoAPI WPT tests
  • Add ML-DSA as an Public Key algorithm to LibCrypto
  • Exposes ML-DSA through WebCryptoAPI

The re-import was needed as a lot of helper scripts had changed to accommodate the new key format these algorithms introduce.

The main code additions are in LibCrypto as the changes in LibWeb as mostly the boilerplate code needed by the spec and even then all the additions are exposing Openssl functionality.

This changes represent an increase 1600+ WPT subtests and making Ladybird the first major browser to support Quantum Secure algorithms for the web in WebCryptoAPI.

@tete17 tete17 requested a review from alimpfard as a code owner November 25, 2025 19:06
@tete17 tete17 force-pushed the PostQuantumCrypto branch 2 times, most recently from 93fc190 to ed61251 Compare November 25, 2025 19:15
@R-Goc
Copy link
Contributor

R-Goc commented Nov 25, 2025

Could this get the Windows label just because of the sheer size? Also all the other crypto algorithms have tests under Tests/LibCrypto. While this does have tests from WPT, I think it would be good for it to have some tests of its own too, but that is a maintainer decision.

@gmta gmta added the windows Related to the Windows platform; on PRs this triggers a Windows CI build label Nov 25, 2025
@tete17 tete17 force-pushed the PostQuantumCrypto branch 2 times, most recently from eb02b00 to 832d74c Compare November 26, 2025 00:40
@tete17
Copy link
Contributor Author

tete17 commented Nov 26, 2025

@R-Goc I added some test for LibCrypto but they are brutal, public keys are massive.

There is some randomness to the signing which means I can't verify with a fixed test data.

@github-actions
Copy link

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Nov 27, 2025
@github-actions github-actions bot removed the conflicts Pull request has merge conflicts that need resolution label Nov 27, 2025
@github-actions
Copy link

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Nov 27, 2025
@github-actions github-actions bot removed the conflicts Pull request has merge conflicts that need resolution label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

windows Related to the Windows platform; on PRs this triggers a Windows CI build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants