-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Integrate ML-DSA postquantum algorithm into WebCryptoAPI #6935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
93fc190 to
ed61251
Compare
|
Could this get the Windows label just because of the sheer size? Also all the other crypto algorithms have tests under Tests/LibCrypto. While this does have tests from WPT, I think it would be good for it to have some tests of its own too, but that is a maintainer decision. |
eb02b00 to
832d74c
Compare
|
@R-Goc I added some test for LibCrypto but they are brutal, public keys are massive. There is some randomness to the signing which means I can't verify with a fixed test data. |
832d74c to
f701d33
Compare
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
f701d33 to
44286ce
Compare
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
Some test have changed name and some utilities have now expanded to accommodate new algorithms.
This is the first post quantum algorith in the project
It is a remnant of serenityos and doesn't make sense in non RSA algorithms.
This is the first post quantum algorith in the project
This represents 1600+ subtests, including the worker tests.
44286ce to
78b5ffb
Compare
This MR achieves 3 things:
The re-import was needed as a lot of helper scripts had changed to accommodate the new key format these algorithms introduce.
The main code additions are in LibCrypto as the changes in LibWeb as mostly the boilerplate code needed by the spec and even then all the additions are exposing Openssl functionality.
This changes represent an increase 1600+ WPT subtests and making Ladybird the first major browser to support Quantum Secure algorithms for the web in WebCryptoAPI.