Issue 46962: Fix decoding of paths containing encoded commas

[labkey-susanh]

Rationale

decodeURI chooses not to decode encoded commas (presumably because encodeURI also does nothing with commas) (even though decodeURIComponent does the right thing). This can be problematic since encoding of commas is actually recommended (and done on the server side).

Related Pull Requests

Changes

• Add own decodeURI method to handle decoding of commas as well.

[labkey-nicka]

This is why:

So should we consider any of these other characters? Also, just curious, where did you see that it is recommended to encode them?

[labkey-susanh]

Here, for example: https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding

[labkey-susanh]

Thanks for that pointer. I think in this usage, since we've already identified the part that's being decoded as a container path, which shouldn't include parts where these characters have meaning in the URI syntax, it should be safe to decode all of these characters (so they don't get double encoded later). Thoughts?

[labkey-susanh]

Ah, but we prevent the use of many of these characters in folder names. We allow ;, @, &, =, $, ,, and #. Perhaps we should expand the set of not allowed characters, but there may be some weird ones in the wild already.

[labkey-susanh]

@labkey-nicka I've update the method to decode the other characters that are valid in project names but encoded by URI encoding. I believe returning the fully decoded path is what we want here since previously that is what was expected, just not being done. Happy to discuss, though.

[labkey-nicka]

I think what you've done works.