fix upConv usage #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the help of `upConv` says: ``` >> help upConv RES = upConv(IM, FILT, EDGES, STEP, START, STOP, RES) ... RES is an optional result matrix. The convolution result will be destructively added into this matrix. If this argument is passed, the result matrix will not be returned. DO NOT USE THIS ARGUMENT IF YOU DO NOT UNDERSTAND WHAT THIS MEANS!! ... ``` So, what you can do here is to modify the code: 1. Not to pass the `RES` input argument 2. Not to receive the `RES` output argument The problem with the following code is that `res` exists both on the left side and right side. https://github.com/LabForComputationalVision/matlabPyrTools/blob/42e4602dd06a36282b16123e7f587c08f397b272/reconSpyr.m#L94 According to the `upConv` usage in reconSpyr.m, and reconSpyrLevs.m, the `res` variable is created in proper size and type, so you should omit the left side `res` output argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will solve the problem reported in #4.
As the help of
upConvsays:So, what you can do here is to modify the code:
RESinput argumentRESoutput argumentThe problem with the following code is that
resexists both on the left side and right side.matlabPyrTools/reconSpyr.m
Line 94 in 42e4602
According to the
upConvusage in reconSpyr.m, and reconSpyrLevs.m, theresvariable is created in proper size and type, so you should omit the left sideresoutput argument.